Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored edge loader #509

Merged
merged 5 commits into from
Sep 22, 2021
Merged

Refactored edge loader #509

merged 5 commits into from
Sep 22, 2021

Conversation

siyuan0322
Copy link
Member

@siyuan0322 siyuan0322 commented Sep 21, 2021

Make the loading fragment a unified process both for load EV or load E, which is

  • Preprocess all edge tables to find vertex tables that need to be deduced,
  • Add these deduced vertex tables together with users provided,
  • Add the edge tables.

And to make the code reusable, the EFragmentLoader now becomes a utility class and renamed to FragmentLoaderUtils,
mainly focus on the preprocessing works.

@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #509 (af1af70) into main (6a3f575) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #509      +/-   ##
==========================================
- Coverage   70.13%   70.09%   -0.05%     
==========================================
  Files          63       63              
  Lines        5646     5645       -1     
==========================================
- Hits         3960     3957       -3     
- Misses       1686     1688       +2     
Impacted Files Coverage Δ
src/server/vineyardd.cc 81.39% <0.00%> (-4.97%) ⬇️

@siyuan0322
Copy link
Member Author

/hold until the CI of alibaba/GraphScope#855 turned green.

Copy link
Member

@sighingnow sighingnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please brief the major changes in this pull request in the description?

@siyuan0322
Copy link
Member Author

siyuan0322 commented Sep 22, 2021

Could you please brief the major changes in this pull request in the description?

Sorry I only put the description in the GraphScope side. I will copy it here.

siyuan0322 and others added 4 commits September 22, 2021 19:45
Signed-off-by: siyuan0322 <siyuanzhang.zsy@alibaba-inc.com>
Signed-off-by: siyuan0322 <siyuanzhang.zsy@alibaba-inc.com>
Signed-off-by: siyuan0322 <siyuanzhang.zsy@alibaba-inc.com>
Signed-off-by: siyuan0322 <siyuan0322@gmail.com>
Signed-off-by: siyuan0322 <siyuan0322@gmail.com>
@siyuan0322 siyuan0322 merged commit 9b70e8a into v6d-io:main Sep 22, 2021
@siyuan0322 siyuan0322 deleted the zsy/loader branch September 22, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants