Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSVC compatibility #6

Closed
mossheim opened this issue Feb 11, 2021 · 2 comments · Fixed by #7
Closed

MSVC compatibility #6

mossheim opened this issue Feb 11, 2021 · 2 comments · Fixed by #7

Comments

@mossheim
Copy link
Contributor

I noticed these UGens do not compile under Windows MSVC 2019. Would you have any interest in accepting a PR to add support for that compiler? I played with it a bit last night and got a few of the components in this repo compiling without too many changes.
@v7b1
Copy link
Owner

v7b1 commented Feb 11, 2021

Yes, sure. I can't test/verify the necessary changes for windows, though.

@mossheim
Copy link
Contributor Author

OK!

I could look into adding a github actions workflow too if you're open to it.

@mossheim mossheim mentioned this issue Feb 11, 2021
Merged
@v7b1 v7b1 closed this as completed in #7 Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MSVC compatibility mossheim/mi-UGens
2 participants
@v7b1 @mossheim