Skip to content

Commit

Permalink
Fix javadocs for getId() and setId() (#4960)
Browse files Browse the repository at this point in the history
For some reason, the javadoc was based on representing absence of id as
`null`, whereas the implementation uses empty string in the setter and
empty optional in the getter.
  • Loading branch information
Legioth authored and ujoni committed Feb 18, 2019
1 parent a97dcf5 commit 2c38284
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -383,8 +383,8 @@ public Optional<UI> getUI() {
* page.
*
* @param id
* the id to set, or <code>null</code> to remove any previously
* set id
* the id to set, or <code>""</code> to remove any previously set
* id
*/
public void setId(String id) {
set(idDescriptor, id);
Expand All @@ -395,7 +395,7 @@ public void setId(String id) {
*
* @see #setId(String)
*
* @return the id, or <code>""</code> if no id has been set
* @return the id, or and empty optional if no id has been set
*/
public Optional<String> getId() {
return get(idDescriptor);
Expand Down

0 comments on commit 2c38284

Please sign in to comment.