Fix javadocs for getId() and setId() #4960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, the javadoc was based on representing absence of id as `null`, whereas the implementation uses empty string in the setter and empty optional in the getter.
|
SonarQube analysis reported 2 issues Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
denis-anisimov
approved these changes
Jan 16, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all discussions resolved, 1 of 1 LGTMs obtained
caalador
pushed a commit
that referenced
this pull request
Jan 30, 2019
For some reason, the javadoc was based on representing absence of id as `null`, whereas the implementation uses empty string in the setter and empty optional in the getter.
pleku
pushed a commit
that referenced
this pull request
Feb 14, 2019
For some reason, the javadoc was based on representing absence of id as `null`, whereas the implementation uses empty string in the setter and empty optional in the getter.
pleku
pushed a commit
that referenced
this pull request
Feb 14, 2019
For some reason, the javadoc was based on representing absence of id as `null`, whereas the implementation uses empty string in the setter and empty optional in the getter.
mehdi-vaadin
pushed a commit
that referenced
this pull request
Feb 14, 2019
For some reason, the javadoc was based on representing absence of id as `null`, whereas the implementation uses empty string in the setter and empty optional in the getter.
ujoni
pushed a commit
that referenced
this pull request
Feb 18, 2019
For some reason, the javadoc was based on representing absence of id as `null`, whereas the implementation uses empty string in the setter and empty optional in the getter.
Merged
ujoni
pushed a commit
that referenced
this pull request
Feb 18, 2019
For some reason, the javadoc was based on representing absence of id as `null`, whereas the implementation uses empty string in the setter and empty optional in the getter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, the javadoc was based on representing absence of id as
null, whereas the implementation uses empty string in the setter andempty optional in the getter.
This change is