Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vite] Create a configuration for type checking (from TypeScript) in production builds #12114

Closed
gilberto-torrezan opened this issue Oct 22, 2021 · 2 comments · Fixed by #12344
Closed

[Vite] Create a configuration for type checking (from TypeScript) in production builds #12114

gilberto-torrezan opened this issue Oct 22, 2021 · 2 comments · Fixed by #12344
Assignees
@joheriks
Labels
enhancement prerelease version for platform 22.0.0 Released with Platform 22.0.0.rc1 vite Tickets related to vite support
Projects
Frontend build optimization

Comments

@gilberto-torrezan
Copy link
Contributor

As noted in this ticket, by default Vite doesn't do any type checking of the code, and leaves that for the developer's IDE.

This can lead to problems when the IDEs of developers are not reliable (such in an open source project with external contributions). There should be some configuration to prevent code with type errors from being merged to mainstream and deployed to production.
@gilberto-torrezan gilberto-torrezan added enhancement vite Tickets related to vite support labels Oct 22, 2021
@gilberto-torrezan gilberto-torrezan added this to To do in Frontend build optimization via automation Oct 22, 2021
@gilberto-torrezan
Copy link
Contributor Author

There's this plugin for example: https://github.com/fi3ework/vite-plugin-checker

@joheriks joheriks moved this from To do to In progress in Frontend build optimization Nov 11, 2021
@joheriks joheriks self-assigned this Nov 11, 2021
@joheriks joheriks mentioned this issue Nov 12, 2021
Merged
Frontend build optimization automation moved this from In progress to Done Nov 17, 2021
Artur- pushed a commit that referenced this issue Nov 17, 2021
feat: Add typescript checker plugin (#12344)
81bd546 
Fixes #12114
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 22.0.0.rc1 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joheriks joheriks

Labels
enhancement prerelease version for platform 22.0.0 Released with Platform 22.0.0.rc1 vite Tickets related to vite support
Projects
Frontend build optimization
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add typescript checker plugin vaadin/flow
3 participants
@joheriks @gilberto-torrezan @vaadin-bot