feat: Add typescript checker plugin #12344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caalador
previously approved these changes
Nov 12, 2021
|
Does this have any performance impact? |
|
Testing with https://github.com/vaadin/fusion-crm-tutorial (30 and without checking (disabling the plugin): Noticed some other problems though that should block this PR from getting merged:
|
joheriks
force-pushed
the
vite-plugin-checker
branch
from
02e79a8
to
51cda66
Compare
Seems I only had incomplete local installation due to the npm peer dependency issue due to the Vite |
Artur-
approved these changes
Nov 15, 2021
|
This ticket/PR has been released with platform 22.0.0.rc1 and is also targeting the upcoming stable 22.0.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable https://github.com/fi3ework/vite-plugin-checker
Closes #12114