Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vite does not work when project directory name contains spaces #12221

Closed
Artur- opened this issue Nov 1, 2021 · 1 comment · Fixed by #12225
Closed

Vite does not work when project directory name contains spaces #12221

Artur- opened this issue Nov 1, 2021 · 1 comment · Fixed by #12225
Assignees
@Artur-
Labels
prerelease version for platform 22.0.0 Released with Platform 22.0.0.beta2 vite Tickets related to vite support
Projects
Frontend build optimization

Comments

@Artur-
Copy link
Member

Artur- commented Nov 1, 2021

Running a project in .../my-app 25 fails when it is trying load files from
http://localhost:13484/VAADIN/@fs/.../my-app%2025/target/flow-frontend/VaadinDevmodeGizmo.js. These request end in

Whitelabel Error Page
This application has no explicit mapping for /error, so you are seeing this as a fallback.

Mon Nov 01 15:39:32 EET 2021
There was an unexpected error (type=Bad Request, status=400).
No message available

Renaming the folder to .../my-app25 works around the problem
@Artur- Artur- self-assigned this Nov 1, 2021
Artur- added a commit that referenced this issue Nov 1, 2021
@Artur-
fix: Use encoded path for dev server
d0afca8 
Allows project folders with spaces to work

Fixes #12221
Artur- added a commit that referenced this issue Nov 1, 2021
@Artur-
fix: Use encoded path for dev server
f6b583a 
Allows project folders with spaces to work

Fixes #12221
@Artur- Artur- mentioned this issue Nov 1, 2021
Merged
Artur- added a commit that referenced this issue Nov 2, 2021
@Artur-
fix: Use encoded path for dev server
76b8939 
Allows project folders with spaces to work

Fixes #12221
Artur- added a commit that referenced this issue Nov 2, 2021
@Artur-
fix: Use encoded path for dev server
367a21b 
Allows project folders with spaces to work

Fixes #12221
caalador pushed a commit that referenced this issue Nov 2, 2021
@Artur-
fix: Use encoded path for dev server (#12225)
bde9fff 
Allows project folders with spaces to work

Fixes #12221
@Artur- Artur- added this to To do in Frontend build optimization via automation Nov 5, 2021
@Artur- Artur- added the vite Tickets related to vite support label Nov 5, 2021
@caalador caalador moved this from To do to Done in Frontend build optimization Nov 12, 2021
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 22.0.0.beta2 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Artur- Artur-

Labels
prerelease version for platform 22.0.0 Released with Platform 22.0.0.beta2 vite Tickets related to vite support
Projects
Frontend build optimization
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Use encoded path for dev server vaadin/flow
2 participants
@Artur- @vaadin-bot