Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use encoded path for dev server #12225

Merged
merged 3 commits into from Nov 2, 2021
Merged

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Nov 1, 2021

Allows project folders with spaces to work

Fixes #12221

@Artur- Artur- added the vite Tickets related to vite support label Nov 1, 2021
@Artur- Artur- added this to In progress in Frontend build optimization via automation Nov 1, 2021
@Artur- Artur- force-pushed the fix-encoding-in-dev-server-req branch from f6b583a to 76b8939 Compare November 2, 2021 08:22
Allows project folders with spaces to work

Fixes #12221
@Artur- Artur- force-pushed the fix-encoding-in-dev-server-req branch from 76b8939 to 367a21b Compare November 2, 2021 10:40
@caalador
Copy link
Contributor

caalador commented Nov 2, 2021

org.junit.ComparisonFailure: expected:<[/]foo%20bar> but was:<[]foo%20bar>
  at org.junit.Assert.assertEquals(Assert.java:117)
  at org.junit.Assert.assertEquals(Assert.java:146)
  at com.vaadin.base.devserver.AbstractDevServerRunnerTest.shouldPassEncodedUrlToDevServer(AbstractDevServerRunnerTest.java:99)

@Artur-
Copy link
Member Author

Artur- commented Nov 2, 2021

Fixed test now that pathinfo is used again

caalador
caalador previously approved these changes Nov 2, 2021
@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 6 issues

  1. MAJOR AbstractDevServerRunner.java#L114: Make "devServerStartFuture" transient or serializable. rule
  2. MAJOR AbstractDevServerRunner.java#L191: Invoke method(s) only conditionally. rule
  3. MAJOR AbstractDevServerRunner.java#L380: Either re-interrupt this method or rethrow the "InterruptedException". rule
  4. MAJOR AbstractDevServerRunner.java#L601: Null passed for non-null parameter of java.util.concurrent.CompletableFuture.getNow(Object) in com.vaadin.base.devserver.AbstractDevServerRunner.handleRequest(VaadinSession, VaadinRequest, VaadinResponse) rule
  5. MAJOR AbstractDevServerRunner.java#L662: Refactor this method to reduce its Cognitive Complexity from 18 to the 15 allowed. rule
  6. MINOR AbstractDevServerRunner.java#L632: Replace this if-then-else statement by a single return statement. rule

@caalador caalador merged commit bde9fff into master Nov 2, 2021
Frontend build optimization automation moved this from In progress to Done Nov 2, 2021
@caalador caalador deleted the fix-encoding-in-dev-server-req branch November 2, 2021 14:23
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 22.0.0.beta2 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Vite does not work when project directory name contains spaces
3 participants