Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to new auto configuration in spring boot. The spring.factories support for auto configuration was removed in spring boot 3.0.0-M5. #14628

Closed
aspan opened this issue Sep 23, 2022 · 2 comments · Fixed by #14659

Comments

@aspan
Copy link
Contributor

aspan commented Sep 23, 2022

Description of the bug

Adapt to new auto configuration in spring boot. The spring.factories support for auto configuration was removed in spring boot 3.0.0-M5 spring-projects/spring-boot#29699 and the current auto configuration has to be moved to a new location.

Expected behavior

The application should auto configure spring beans.

Minimal reproducible example

Create a new project from the starter. Change to user vaadin flow 24.0.0.alpha1 and upgrade spring boot to 3.0.0-M5.

Versions

  • Flow version: 24.0.0.alpha1
  • Spring boot: 3.0.0-M5
@mshabarov mshabarov self-assigned this Sep 27, 2022
@mshabarov mshabarov moved this from Next for Dev. Team to Work In Progress in Vaadin Flow enhancements backlog (Vaadin 10+) Sep 27, 2022
mshabarov added a commit that referenced this issue Sep 27, 2022
Spring Boot introduced a new location for auto configuration entries in spring boot 2.7.0. The new location is META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports. This has until spring boot 3.0.0-M5 worked in parallel with the spring.factories configuration.
The spring.factories support was removed in spring boot 3.0.0-M5 so this move has to be done now in order for the auto configuration to be picked up.

Fixes #14628
mshabarov pushed a commit that referenced this issue Sep 28, 2022
Spring Boot introduced a new location for auto configuration entries in spring boot 2.7.0. The new location is META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports. This has until spring boot 3.0.0-M5 worked in parallel with the spring.factories configuration.
The spring.factories support was removed in spring boot 3.0.0-M5 so this move has to be done now in order for the auto configuration to be picked up.

Fixes #14628
mshabarov added a commit that referenced this issue Sep 28, 2022
Spring Boot introduced a new location for auto configuration entries in spring boot 2.7.0. The new location is META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports. This has until spring boot 3.0.0-M5 worked in parallel with the spring.factories configuration. The spring.factories support was removed in spring boot 3.0.0-M5 so this move has to be done now in order for the auto configuration to be picked up.

Fixes #14628

Picked to master from #14629

Co-authored-by: @aspan
OLD Vaadin Flow ongoing work (Vaadin 10+) automation moved this from In progress to Done - pending release Sep 28, 2022
Vaadin Flow enhancements backlog (Vaadin 10+) automation moved this from Work In Progress to Done / Pending Release Sep 28, 2022
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 23.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
OLD Vaadin Flow ongoing work (Vaadin ...
  
Done - pending release
Vaadin Flow enhancements backlog (Vaa...
  
Done / Pending Release
Development

Successfully merging a pull request may close this issue.

4 participants