Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adapt to a new auto configuration in Spring Boot #14629

Merged
merged 2 commits into from Sep 28, 2022
Merged

feat: Adapt to a new auto configuration in Spring Boot #14629

merged 2 commits into from Sep 28, 2022

Conversation

aspan
Copy link
Contributor

@aspan aspan commented Sep 23, 2022

Description

Spring Boot introduced a new location for auto configuration entries in spring boot 2.7.0. The new location is META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports. This has until spring boot 3.0.0-M5 worked in parallel with the spring.factories configuration.
The spring.factories support was removed in spring boot 3.0.0-M5 so this move has to be done now in order for the auto configuration to be picked up.

Fixes #14628

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

…support for auto configuration was removed in spring boot 3.0.0-M5.
@CLAassistant
Copy link

CLAassistant commented Sep 23, 2022

CLA assistant check
All committers have signed the CLA.

@mcollovati mcollovati added the Contribution PRs coming from the community or external to the team label Sep 23, 2022
@github-actions
Copy link

github-actions bot commented Sep 23, 2022

Unit Test Results

   919 files  ±0     919 suites  ±0   51m 20s ⏱️ - 2m 29s
6 026 tests ±0  5 973 ✔️ ±0  53 💤 ±0  0 ±0 
6 248 runs   - 3  6 188 ✔️  - 3  60 💤 ±0  0 ±0 

Results for commit 893bb2f. ± Comparison against base commit f970961.

♻️ This comment has been updated with latest results.

@mcollovati
Copy link
Collaborator

Thanks for the contribution

mcollovati
mcollovati previously approved these changes Sep 23, 2022
@Artur-
Copy link
Member

Artur- commented Sep 23, 2022

Should this be done for master?

@mshabarov
Copy link
Contributor

@Artur- @aspan current master uses Spring Boot 2.7, so I think this patch can target master. I will make a PR to master soon.
@aspan thanks for contribution!

Copy link
Contributor

@mshabarov mshabarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also made a patch for master #14659

@mshabarov mshabarov changed the title Adapt to new auto configuration in spring boot. The spring.factories … feat: Adapt to a new auto configuration in Spring Boot Sep 27, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mshabarov mshabarov merged commit d2a125c into vaadin:24.0 Sep 28, 2022
OLD Vaadin Flow ongoing work (Vaadin 10+) automation moved this from Iteration Reviews to Done - pending release Sep 28, 2022
mshabarov added a commit that referenced this pull request Sep 28, 2022
Spring Boot introduced a new location for auto configuration entries in spring boot 2.7.0. The new location is META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports. This has until spring boot 3.0.0-M5 worked in parallel with the spring.factories configuration. The spring.factories support was removed in spring boot 3.0.0-M5 so this move has to be done now in order for the auto configuration to be picked up.

Fixes #14628

Picked to master from #14629

Co-authored-by: @aspan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution PRs coming from the community or external to the team +1.0.0
Projects
OLD Vaadin Flow ongoing work (Vaadin ...
  
Done - pending release
Development

Successfully merging this pull request may close these issues.

None yet

7 participants