-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stricter TS checks in Vaadin 23.3.0 #15485
Comments
So what has changed as the options are still the same? Is it because of upgrading Typescript from 4.7 to 4.9? |
Principal name usually refers to a user identifier that can be used to retrieve additional details. Fixes #15485
It seems so, although I cannot fully parse the TypeScript release notes. Spelling out the details for one of the example cases I mentiones above:
|
It just hit me what the change is: the files from addons are validated as part of the build as they are placed inside frontend/generated/jar-resources. That folder should be excluded as you cannot change the code in the addons |
I am facing the same issue in a multi module project I am working on. |
The TS files that come from JAR files are not under control of the project developer so enforcing project TS rules on them does not make sense. This is similar to "skipLibCheck" used for TS files that are in node_modules. Fixes #15485
@probert94 Try adding
to your tsconfig.json. This is also what is done in #15700 for future versions |
It seems like |
The TS files that come from JAR files are not under control of the project developer so enforcing project TS rules on them does not make sense. This is similar to "skipLibCheck" used for TS files that are in node_modules. Fixes #15485
The TS files that come from JAR files are not under control of the project developer so enforcing project TS rules on them does not make sense. This is similar to "skipLibCheck" used for TS files that are in node_modules. Fixes #15485
Now I am confused because #15700 does seem to work.. |
Just noting that I applied the workaround in a couple of projects and addons, and it works fine. |
The TS files that come from JAR files are not under control of the project developer so enforcing project TS rules on them does not make sense. This is similar to "skipLibCheck" used for TS files that are in node_modules. Fixes #15485
The TS files that come from JAR files are not under control of the project developer so enforcing project TS rules on them does not make sense. This is similar to "skipLibCheck" used for TS files that are in node_modules. Fixes #15485
The TS files that come from JAR files are not under control of the project developer so enforcing project TS rules on them does not make sense. This is similar to "skipLibCheck" used for TS files that are in node_modules. Fixes #15485
… (CP: 23.3) (#15803) * fix: Do not perform type checking for TS files from jar files (#15700) The TS files that come from JAR files are not under control of the project developer so enforcing project TS rules on them does not make sense. This is similar to "skipLibCheck" used for TS files that are in node_modules. Fixes #15485 * add import --------- Co-authored-by: Artur <artur@vaadin.com>
This ticket/PR has been released with Vaadin 24.0.0.alpha10 and is also targeting the upcoming stable 24.0.0 version. |
This ticket/PR has been released with Vaadin 23.3.6. |
Description of the bug
Vaadin 23.3.0 seems to introduce stricter TS checks by default.
I had to configure the following in
tsconfig.json
in order to run applications that were working fine with Vaadin 23.2:(
noImplicitAny
andnoImplicitThis
were alreadytrue
with Vaadin 23.2, but now they flag additional errors.)See some sample error logs in FlowingCode/FontAwesomeIronIconset#56
The new stricter defaults are problematic, since they also affect third-party components (addons), which may rely on loose checks.
Expected behavior
Since it's not documented as a breaking change, I would expect no additional TS errors when upgrading from Vaadin 23.2 to Vaadin 23.3.0.
Minimal reproducible example
See https://github.com/FlowingCode/FontAwesomeIronIconset/tree/font-awesome-iron-iconset-4.2.0 (fixed in FlowingCode/FontAwesomeIronIconset#58)
and https://github.com/FlowingCode/XTermConsoleAddon/commits/xterm-console-2.1.0 (fixed in FlowingCode/XTermConsoleAddon#66)
The application runs with no issues up to vaadin 23.2 (
mvn jetty:run
), but it fails with TS errors with vaadin 23.3 and 24.Versions
The text was updated successfully, but these errors were encountered: