Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: property synchronization events cause a value flush #15615

Closed
vursen opened this issue Jan 2, 2023 · 9 comments · Fixed by #15583 or #17410
Closed

Regression: property synchronization events cause a value flush #15615

vursen opened this issue Jan 2, 2023 · 9 comments · Fixed by #15583 or #17410
Assignees
@mcollovati
Labels
prerelease version for Vaadin 14.10.0 prerelease version for Vaadin 24.0.0 regression Released with Vaadin 14.9.5 Released with Vaadin 14.10.0.alpha1 Released with Vaadin 22.0.28 Released with Vaadin 23.2.15 Released with Vaadin 23.3.5 Released with Vaadin 24.0.0.alpha10
Projects
OLD Vaadin Flow bugs & maintenance (V...

Comments

@vursen
Copy link
Contributor

vursen commented Jan 2, 2023 •
edited

Description of the bug

A regression introduced in #14090

When changing the value of NumberField from "" to "1" back and forth, the validation starts behaving weirdly (see the recording). As follows from the server logs, changing the value that way sometimes causes a value flush, but the flushed value is always the previous one.

In this specific case, the reason is the has-input-value-changed event that results from the @Synchronize annotation and that causes a value flush. This event is fired before value-changed so an old value is flushed.

Recording

Screen.Recording.2022-12-28.at.17.04.08.mov

Expected behavior

Property synchronization events should not be treated as triggered by the user and hence should not cause a value flush.

Minimal reproducible example

NumberField numberField = new NumberField();
numberField.setValueChangeMode(ValueChangeMode.LAZY);
numberField.setValueChangeTimeout(5000);
numberField.addValueChangeListener(event -> {
    System.out.println("New value: " + event.getValue());
});
add(numberField);

Versions

  • Vaadin / Flow version: 24
  • Java version: 17
  • OS version: Mac OS
@mcollovati
Copy link
Collaborator

PR #15583 may fix this

@MarcinVaadin
Copy link
Member

@vursen may you have a look at #15583 ?

@vursen
Copy link
Contributor Author

vursen commented Jan 9, 2023 •
edited

may you have a look at #15583 ?

@MarcinVaadin Yes, I left my feedback there already.

@mcollovati mcollovati self-assigned this Jan 9, 2023
@mcollovati mcollovati added this to Needs triage in OLD Vaadin Flow bugs & maintenance (Vaadin 10+) via automation Jan 9, 2023
mcollovati added a commit that referenced this issue Jan 10, 2023
@mcollovati
fix: prevent flush changes when synchronizing properties
c8458a8 
DOM events related to property synchronization must not flush changes
to avoid wrong execution order of events on server side.
For example, an 'has-input-value-changed' event may occur before the
actual value of a field has been changed and a flush will trigger
listeners with an old value.

Fixes #15615
@mcollovati mcollovati mentioned this issue Jan 10, 2023
Merged
mcollovati added a commit that referenced this issue Jan 10, 2023
@mcollovati
fix: prevent flush changes when synchronizing properties
4673fff 
DOM events related to property synchronization must not flush changes
to avoid wrong execution order of events on server side.
For example, an 'has-input-value-changed' event may occur before the
actual value of a field has been changed and a flush will trigger
listeners with an old value.

Fixes #15615
mcollovati added a commit that referenced this issue Jan 20, 2023
@mcollovati
fix: prevent flush changes when synchronizing properties (#15583)
6adb7e9 
DOM events related to property synchronization must not flush changes
to avoid wrong execution order of events on server side.
For example, an 'has-input-value-changed' event may occur before the
actual value of a field has been changed and a flush will trigger
listeners with an old value.

Fixes #15615
OLD Vaadin Flow bugs & maintenance (Vaadin 10+) automation moved this from WIP to Closed Jan 20, 2023
vaadin-bot pushed a commit that referenced this issue Jan 20, 2023
@mcollovati @vaadin-bot
fix: prevent flush changes when synchronizing properties (#15583)
fcee610 
DOM events related to property synchronization must not flush changes
to avoid wrong execution order of events on server side.
For example, an 'has-input-value-changed' event may occur before the
actual value of a field has been changed and a flush will trigger
listeners with an old value.

Fixes #15615
vaadin-bot pushed a commit that referenced this issue Jan 20, 2023
@mcollovati @vaadin-bot
fix: prevent flush changes when synchronizing properties (#15583)
cb891b5 
DOM events related to property synchronization must not flush changes
to avoid wrong execution order of events on server side.
For example, an 'has-input-value-changed' event may occur before the
actual value of a field has been changed and a flush will trigger
listeners with an old value.

Fixes #15615
vaadin-bot pushed a commit that referenced this issue Jan 20, 2023
@mcollovati @vaadin-bot
fix: prevent flush changes when synchronizing properties (#15583)
3c6aad2 
DOM events related to property synchronization must not flush changes
to avoid wrong execution order of events on server side.
For example, an 'has-input-value-changed' event may occur before the
actual value of a field has been changed and a flush will trigger
listeners with an old value.

Fixes #15615
vaadin-bot pushed a commit that referenced this issue Jan 20, 2023
@mcollovati @vaadin-bot
fix: prevent flush changes when synchronizing properties (#15583)
1d3270b 
DOM events related to property synchronization must not flush changes
to avoid wrong execution order of events on server side.
For example, an 'has-input-value-changed' event may occur before the
actual value of a field has been changed and a flush will trigger
listeners with an old value.

Fixes #15615
vaadin-bot added a commit that referenced this issue Jan 20, 2023
@vaadin-bot @mcollovati
fix: prevent flush changes when synchronizing properties (#15583) (#1…
91e6845 
…5722)

DOM events related to property synchronization must not flush changes
to avoid wrong execution order of events on server side.
For example, an 'has-input-value-changed' event may occur before the
actual value of a field has been changed and a flush will trigger
listeners with an old value.

Fixes #15615

Co-authored-by: Marco Collovati <marco@vaadin.com>
vaadin-bot added a commit that referenced this issue Jan 20, 2023
@vaadin-bot @mcollovati
fix: prevent flush changes when synchronizing properties (#15583) (#1…
945c585 
…5723)

DOM events related to property synchronization must not flush changes
to avoid wrong execution order of events on server side.
For example, an 'has-input-value-changed' event may occur before the
actual value of a field has been changed and a flush will trigger
listeners with an old value.

Fixes #15615

Co-authored-by: Marco Collovati <marco@vaadin.com>
vaadin-bot added a commit that referenced this issue Jan 20, 2023
@vaadin-bot @mcollovati
fix: prevent flush changes when synchronizing properties (#15583) (#1…
fa69bbf 
…5725)

DOM events related to property synchronization must not flush changes
to avoid wrong execution order of events on server side.
For example, an 'has-input-value-changed' event may occur before the
actual value of a field has been changed and a flush will trigger
listeners with an old value.

Fixes #15615

Co-authored-by: Marco Collovati <marco@vaadin.com>
vaadin-bot added a commit that referenced this issue Jan 20, 2023
@vaadin-bot @mcollovati
fix: prevent flush changes when synchronizing properties (#15583) (#1…
4c33bc7 
…5724)

DOM events related to property synchronization must not flush changes
to avoid wrong execution order of events on server side.
For example, an 'has-input-value-changed' event may occur before the
actual value of a field has been changed and a flush will trigger
listeners with an old value.

Fixes #15615

Co-authored-by: Marco Collovati <marco@vaadin.com>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 23.3.5.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 23.2.15.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 22.0.28.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 14.9.5.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 14.10.0.alpha1 and is also targeting the upcoming stable 14.10.0 version.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.0.0.alpha10 and is also targeting the upcoming stable 24.0.0 version.

@mstahv mstahv mentioned this issue Aug 11, 2023
Merged
8 tasks
mshabarov added a commit that referenced this issue Aug 22, 2023
@mstahv @mcollovati @mshabarov
fix: fixes and optimises everything regarding event debouncing (#17410)
349945a 
The event order when using debouncing sends events in wrong order. This was tried to be fixed in #14035 but apparently only issues with the core TextField was fixed (or then this was again regressed in the regression fix #15615) 

---------

Co-authored-by: Marco Collovati <marco@vaadin.com>
Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
vaadin-bot pushed a commit that referenced this issue Aug 30, 2023
@mstahv @mcollovati
@mshabarov @vaadin-bot
fix: fixes and optimises everything regarding event debouncing (#17410)
e9cef29 
The event order when using debouncing sends events in wrong order. This was tried to be fixed in #14035 but apparently only issues with the core TextField was fixed (or then this was again regressed in the regression fix #15615) 

---------

Co-authored-by: Marco Collovati <marco@vaadin.com>
Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
vaadin-bot added a commit that referenced this issue Aug 30, 2023
@vaadin-bot @mstahv
@mcollovati @mshabarov
fix: fixes and optimises everything regarding event debouncing (#17410)…
b8d6fbd 
… (#17516)

The event order when using debouncing sends events in wrong order. This was tried to be fixed in #14035 but apparently only issues with the core TextField was fixed (or then this was again regressed in the regression fix #15615) 

---------

Co-authored-by: Matti Tahvonen <matti@vaadin.com>
Co-authored-by: Marco Collovati <marco@vaadin.com>
Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
@mstahv mstahv mentioned this issue Sep 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcollovati mcollovati

Labels
prerelease version for Vaadin 14.10.0 prerelease version for Vaadin 24.0.0 regression Released with Vaadin 14.9.5 Released with Vaadin 14.10.0.alpha1 Released with Vaadin 22.0.28 Released with Vaadin 23.2.15 Released with Vaadin 23.3.5 Released with Vaadin 24.0.0.alpha10
Projects
OLD Vaadin Flow bugs & maintenance (V...
Closed
Milestone
No milestone
4 participants
@mcollovati @vursen @vaadin-bot @MarcinVaadin