fix: prevent flush changes when synchronizing properties #15583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollovati
force-pushed
the
fix/flushing_on_dom_events
branch
from
e645d8a
to
9ab636b
Compare
vursen
reviewed
Jan 3, 2023
flow-client/src/main/java/com/vaadin/client/flow/binding/SimpleElementBindingStrategy.java
Outdated
Show resolved
Hide resolved
vursen
reviewed
Jan 3, 2023
flow-client/src/main/java/com/vaadin/client/flow/binding/SimpleElementBindingStrategy.java
Show resolved
Hide resolved
|
Shall we add some tests? |
I'll try to see if I'm able to create at least a GWT test |
mcollovati
force-pushed
the
fix/flushing_on_dom_events
branch
2 times, most recently
from
279a304
to
c8458a8
Compare
DOM events related to property synchronization must not flush changes to avoid wrong execution order of events on server side. For example, an 'has-input-value-changed' event may occur before the actual value of a field has been changed and a flush will trigger listeners with an old value. Fixes #15615
mcollovati
force-pushed
the
fix/flushing_on_dom_events
branch
from
c8458a8
to
4673fff
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Shouldn't this fix be prioritized because the feature it fixes was also backported and is released in 23.3 and below? |
|
@mcollovati The solution looks good to me. As for tests, I would leave that to @manolo to review as I'm not familiar with GWT. |
manolo
approved these changes
Jan 19, 2023
|
Thanks guys 🙇♂️ |
vaadin-bot
pushed a commit
that referenced
this pull request
Jan 20, 2023
DOM events related to property synchronization must not flush changes to avoid wrong execution order of events on server side. For example, an 'has-input-value-changed' event may occur before the actual value of a field has been changed and a flush will trigger listeners with an old value. Fixes #15615
vaadin-bot
pushed a commit
that referenced
this pull request
Jan 20, 2023
DOM events related to property synchronization must not flush changes to avoid wrong execution order of events on server side. For example, an 'has-input-value-changed' event may occur before the actual value of a field has been changed and a flush will trigger listeners with an old value. Fixes #15615
vaadin-bot
pushed a commit
that referenced
this pull request
Jan 20, 2023
DOM events related to property synchronization must not flush changes to avoid wrong execution order of events on server side. For example, an 'has-input-value-changed' event may occur before the actual value of a field has been changed and a flush will trigger listeners with an old value. Fixes #15615
vaadin-bot
pushed a commit
that referenced
this pull request
Jan 20, 2023
DOM events related to property synchronization must not flush changes to avoid wrong execution order of events on server side. For example, an 'has-input-value-changed' event may occur before the actual value of a field has been changed and a flush will trigger listeners with an old value. Fixes #15615
vaadin-bot
added a commit
that referenced
this pull request
Jan 20, 2023
…5722) DOM events related to property synchronization must not flush changes to avoid wrong execution order of events on server side. For example, an 'has-input-value-changed' event may occur before the actual value of a field has been changed and a flush will trigger listeners with an old value. Fixes #15615 Co-authored-by: Marco Collovati <marco@vaadin.com>
vaadin-bot
added a commit
that referenced
this pull request
Jan 20, 2023
…5723) DOM events related to property synchronization must not flush changes to avoid wrong execution order of events on server side. For example, an 'has-input-value-changed' event may occur before the actual value of a field has been changed and a flush will trigger listeners with an old value. Fixes #15615 Co-authored-by: Marco Collovati <marco@vaadin.com>
vaadin-bot
added a commit
that referenced
this pull request
Jan 20, 2023
…5725) DOM events related to property synchronization must not flush changes to avoid wrong execution order of events on server side. For example, an 'has-input-value-changed' event may occur before the actual value of a field has been changed and a flush will trigger listeners with an old value. Fixes #15615 Co-authored-by: Marco Collovati <marco@vaadin.com>
vaadin-bot
added a commit
that referenced
this pull request
Jan 20, 2023
…5724) DOM events related to property synchronization must not flush changes to avoid wrong execution order of events on server side. For example, an 'has-input-value-changed' event may occur before the actual value of a field has been changed and a flush will trigger listeners with an old value. Fixes #15615 Co-authored-by: Marco Collovati <marco@vaadin.com>
|
This ticket/PR has been released with Vaadin 24.0.0.alpha10 and is also targeting the upcoming stable 24.0.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOM events related to property synchronization must not flush changes
to avoid wrong execution order of events on server side.
For example, an 'has-input-value-changed' event may occur before the
actual value of a field has been changed and a flush will trigger
listeners with an old value.
Fixes #15615