Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vaadin 23.3.7: dev mode+Material theme fails with DOMException #16369

Closed
mvysny opened this issue Mar 23, 2023 · 5 comments · Fixed by #16470
Closed

Vaadin 23.3.7: dev mode+Material theme fails with DOMException #16369

mvysny opened this issue Mar 23, 2023 · 5 comments · Fixed by #16470

Comments

@mvysny
Copy link
Member

mvysny commented Mar 23, 2023

Description of the bug

When starting Vaadin 23.3.7 in Dev mode with Material theme, the Main route never gets rendered. The loading progress bar blinks endlessly. There is a JavaScript exception in the console:

Uncaught (in promise) DOMException: CustomElementRegistry.define: 'vaadin-material-styles' has already been defined as a custom element

Cleaning up everything with mvn vaadin:dance doesn't help.

Expected behavior

The main route should be rendered properly.

Minimal reproducible example

Easily reproducible in the skeleton starter:

  1. git clone https://github.com/vaadin/skeleton-starter-flow-spring
  2. git checkout v23
  3. Add @Theme(themeClass = Material.class) to the Application class, and remove CssImports from the MainView.
  4. Run Application.main() via IDE in dev mode.

Note: Production mode works properly.

Versions

  • Vaadin / Flow version: 23.3.7
  • Java version: 17
  • OS version: Ubuntu 22.10
  • Browser version (if applicable): Firefox
  • Application Server (if applicable): Tomcat/Spring Boot
  • IDE (if applicable): Intellij
@mvysny mvysny changed the title Vaadin 23.3.7: dev mode+Material theme blocks endlessly Vaadin 23.3.7: dev mode+Material theme fails with DOMException Mar 23, 2023
@czp13 czp13 added this to Needs triage in OLD Vaadin Flow bugs & maintenance (Vaadin 10+) via automation Mar 28, 2023
@Artur-
Copy link
Member

Artur- commented Mar 30, 2023

This works correctly with Vaadin 24.0.2

@Artur-
Copy link
Member

Artur- commented Mar 30, 2023

Ah, it only works in dev bundle mode

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 23.3.11.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.0.4.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.1.0.alpha3 and is also targeting the upcoming stable 24.1.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment