Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make material styles work in hotdeploy dev mode #16470

Merged
merged 1 commit into from Apr 3, 2023
Merged

fix: Make material styles work in hotdeploy dev mode #16470

merged 1 commit into from Apr 3, 2023

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Mar 30, 2023

Fixes #16369

@Artur- Artur- marked this pull request as ready for review March 30, 2023 13:12
@sonarcloud
Copy link

sonarcloud bot commented Mar 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Test Results

   975 files  ±  0     975 suites  ±0   1h 10m 59s ⏱️ - 3m 24s
6 181 tests ±  0  6 143 ✔️ ±0  38 💤 ±0  0 ❌ ±0 
6 419 runs  +11  6 374 ✔️ +9  45 💤 +2  0 ❌ ±0 

Results for commit a8d9976. ± Comparison against base commit fdf626c.

@czp13 czp13 self-requested a review March 30, 2023 13:33
@Artur- Artur- merged commit d15f537 into main Apr 3, 2023
18 checks passed
@Artur- Artur- deleted the material-vite branch April 3, 2023 10:55
vaadin-bot pushed a commit that referenced this pull request Apr 3, 2023
@Artur- @vaadin-bot
fix: Make material styles work in hotdeploy dev mode (#16470)
793c285 
Fixes #16369
@vaadin-bot
Copy link
Collaborator

Hi @Artur- and @Artur-, when i performed cherry-pick to this commit to 23.3, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick d15f537
error: could not apply d15f537... fix: Make material styles work in hotdeploy dev mode (#16470)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Artur- added a commit that referenced this pull request Apr 3, 2023
@Artur-
fix: Make material styles work in hotdeploy dev mode (#16470) (CP: 23.3)
b7c23be 
Fixes #16369
vaadin-bot added a commit that referenced this pull request Apr 3, 2023
@vaadin-bot @Artur-
fix: Make material styles work in hotdeploy dev mode (#16470) (#16512)
52c3d82 
Fixes #16369

Co-authored-by: Artur <artur@vaadin.com>
Artur- added a commit that referenced this pull request Apr 3, 2023
@Artur-
fix: Make material styles work in hotdeploy dev mode (#16470) (CP: 23…
2595da7 
….3) (#16514)

Fixes #16369
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.1.0.alpha3 and is also targeting the upcoming stable 24.1.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czp13 czp13 czp13 approved these changes

Assignees
No one assigned
Labels
cherry-picked-24.0 need to pick manually 23.3 prerelease version for Vaadin 24.1.0 Released with Vaadin 24.1.0.alpha3 target/23.3 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vaadin 23.3.7: dev mode+Material theme fails with DOMException
3 participants
@Artur- @vaadin-bot @czp13