Update gradle plugin VaadinCleanTask to match maven clean-frontend target #18556
Assignees
Comments
tltv
added a commit
that referenced
this issue
Feb 19, 2024
Updates Vaadin Gradle plugin to clean in same way as Maven plugin cleans. Moved CleanFrontendMojo logic to CleanFrontendUtil in shared flow-plugin-base. Updated VaadinCleanTask and VaadinBuildFrontendTask. Added cleanFrontendFiles property to Gradle plugin. Fixes: #18556
mshabarov
pushed a commit
that referenced
this issue
Feb 22, 2024
* feat: update gradle plugin clean tasks Updates Vaadin Gradle plugin to clean in same way as Maven plugin cleans. Moved CleanFrontendMojo logic to CleanFrontendUtil in shared flow-plugin-base. Updated VaadinCleanTask and VaadinBuildFrontendTask. Added cleanFrontendFiles property to Gradle plugin. Fixes: #18556 * test: added tests * chore: use local stub jar ...instead of using real hilla endpoint. Also removed webpack.generated.js from the task description and javadoc. * chore: extract Options to CleanOptions * docs: added javadoc
|
This ticket/PR has been released with Vaadin 24.4.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe your motivation
Both plugins should clean files in the same way and have the same configuration possibilities.
At the moment for extending the clean task maven has the option to disable removal/cleaning of files and folders where as
gradle doesn't.
Also the gradle task is missing the cleanup of framework manages packages from package.json
Describe the solution you'd like
Cleanup code should possibly be moved into plugin-base and both maven and gradle would call this cleanup code instead of having their own implementations.
Describe alternatives you've considered
Gradle task should be updated to do the same cleanup as its maven counterpart.
The text was updated successfully, but these errors were encountered: