feat: update gradle plugin clean tasks #18756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates Vaadin Gradle plugin to clean in same way as Maven plugin cleans. Moved CleanFrontendMojo logic to CleanFrontendUtil in shared flow-plugin-base. Updated VaadinCleanTask and VaadinBuildFrontendTask. Added cleanFrontendFiles property to Gradle plugin. Fixes: #18556
Test Results1 094 files +1 072 1 094 suites +1 072 1h 19m 34s ⏱️ + 1h 11m 24s Results for commit a441e9f. ± Comparison against base commit 8fe7c27. ♻️ This comment has been updated with latest results. |
mcollovati
requested changes
Feb 20, 2024
flow-plugins/flow-gradle-plugin/src/main/kotlin/com/vaadin/gradle/VaadinCleanTask.kt
Outdated
Show resolved
Hide resolved
flow-plugins/flow-gradle-plugin/src/functionalTest/kotlin/com/vaadin/gradle/VaadinSmokeTest.kt
Outdated
Show resolved
Hide resolved
...instead of using real hilla endpoint. Also removed webpack.generated.js from the task description and javadoc.
mcollovati
previously approved these changes
Feb 21, 2024
|
LGTM, but probably @mshabarov also wants to take a look |
mshabarov
requested changes
Feb 22, 2024
flow-plugins/flow-gradle-plugin/src/functionalTest/kotlin/com/vaadin/gradle/VaadinSmokeTest.kt
Show resolved
Hide resolved
flow-plugins/flow-gradle-plugin/src/functionalTest/kotlin/com/vaadin/gradle/VaadinSmokeTest.kt
Show resolved
Hide resolved
flow-plugins/flow-gradle-plugin/src/functionalTest/kotlin/com/vaadin/gradle/VaadinSmokeTest.kt
Show resolved
Hide resolved
flow-plugins/flow-gradle-plugin/src/main/kotlin/com/vaadin/gradle/VaadinCleanTask.kt
Show resolved
Hide resolved
flow-plugins/flow-gradle-plugin/src/main/kotlin/com/vaadin/gradle/VaadinCleanTask.kt
Show resolved
Hide resolved
flow-plugins/flow-plugin-base/src/main/java/com/vaadin/flow/plugin/base/CleanFrontendUtil.java
Outdated
Show resolved
Hide resolved
mshabarov
reviewed
Feb 22, 2024
flow-plugins/flow-plugin-base/src/main/java/com/vaadin/flow/plugin/base/CleanOptions.java
Outdated
Show resolved
Hide resolved
mshabarov
approved these changes
Feb 22, 2024
|
|
This ticket/PR has been released with Vaadin 24.4.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Vaadin Gradle plugin to clean in same way as Maven plugin cleans. Moved CleanFrontendMojo logic to CleanFrontendUtil in shared flow-plugin-base. Updated VaadinCleanTask and VaadinBuildFrontendTask. Added cleanFrontendFiles property to Gradle plugin.
Fixes: #18556