New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Available routes don't show Hilla views #18857
Comments
tltv
added a commit
that referenced
this issue
Mar 27, 2024
Adds client views in the list of available routes when viewing "Route not found" page in development mode. Adds ClientRoutesProvider interface to get available client routes. Client routes means mainly Hilla views, but not limited to. Fixes: #18857
tltv
added a commit
that referenced
this issue
Mar 27, 2024
Adds client views in the list of available routes when viewing "Route not found" page in development mode. Adds ClientRoutesProvider interface to get available client routes. Client routes means mainly Hilla views, but not limited to. Fixes: #18857
tltv
added a commit
that referenced
this issue
Mar 28, 2024
Adds client views in the list of available routes when viewing "Route not found" page in development mode. Adds ClientRoutesProvider interface to get available client routes. Client routes means mainly Hilla views, but not limited to. Fixes: #18857
tltv
added a commit
that referenced
this issue
Apr 2, 2024
Adds client views in the list of available routes when viewing "Route not found" page in development mode. Adds ClientRoutesProvider interface to get available client routes. Client routes means mainly Hilla views, but not limited to. Fixes: #18857
tltv
added a commit
that referenced
this issue
Apr 3, 2024
* fix: show available client routes Adds client views in the list of available routes when viewing "Route not found" page in development mode. Adds ClientRoutesProvider interface to get available client routes. Client routes means mainly Hilla views, but not limited to. Fixes: #18857 * chore: renamed a method * test: fixed test * chore: removed default ClientRoutesProvider Can't use @ConditionalOnMissingBean as the bean from Hilla dependencies is not reached from here leading to multiple beans which will break things. Therefore, allowing just one implementation of ClientRoutesProvider when Hilla is in the classpath. * chore: support multiple ClientRoutesProviders * chore: cleanup * chore: filter routes starting with $ * chore: filter $layout routes and trim $index * chore: remove default * chore: fixed test * chore: fixed test
This ticket/PR has been released with Vaadin 24.4.0.alpha19 and is also targeting the upcoming stable 24.4.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Describe the bug
In Flow-Hilla hybrid apps like this one, navigating to non-existent routes in dev mode only shows Flow views as available (not the Hilla ones).
Expected-behavior
Both Flow and Hilla views are listed in dev mode.
Reproduction
Running https://github.com/Lodin/hilla-file-router-example, navigate to a non-existent view.
System Info
Vaadin 24.4.0.alpha7
The text was updated successfully, but these errors were encountered: