chore: implement ClientRoutesProvider #2284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClientRoutesProvider interface from flow-server is used by Flow to read a list of available client routes. Hilla can implement it in ClientRouteRegistry, which is already a Spring bean, and this way Flow finds it automatically. Related-to: vaadin/flow/isues/18857
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2284 +/- ##
==========================================
- Coverage 95.22% 93.78% -1.44%
==========================================
Files 66 66
Lines 4290 1642 -2648
Branches 610 369 -241
==========================================
- Hits 4085 1540 -2545
+ Misses 163 67 -96
+ Partials 42 35 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
taefi
approved these changes
Apr 4, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClientRoutesProvider interface from the flow-server is used by Flow to read a list of all available client route paths. Hilla implement it in ClientRouteRegistry bean, which is discovered automatically by Flow.
Related-to: vaadin/flow/issues/18857