Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-install Node 16 #10772

Merged
merged 1 commit into from
May 6, 2021
Merged

Auto-install Node 16 #10772

merged 1 commit into from
May 6, 2021

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Apr 22, 2021

Fixes #10637

@pleku pleku requested a review from mshabarov May 3, 2021 11:44
@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 7 issues

  1. CRITICAL TaskRunNpmInstall.java#L312: Reduce the number of conditional operators (4) used in the expression (maximum allowed 3). rule
  2. MAJOR NodeTasks.java#L1: Class com.vaadin.flow.server.frontend.NodeTasks$Builder defines non-transient non-serializable instance field lookup rule
  3. MAJOR NodeTasks.java#L142: Make "lookup" transient or serializable. rule
  4. MAJOR TaskRunNpmInstall.java#L345: Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed. rule
  5. MINOR FlowModeAbstractMojo.java#L68: Remove this use of "SERVLET_PARAMETER_INITIAL_UIDL"; it is deprecated. rule
  6. MINOR FlowModeAbstractMojo.java#L132: Remove this use of "SERVLET_PARAMETER_ENABLE_PNPM"; it is deprecated. rule
  7. MINOR FlowModeAbstractMojo.java#L157: Remove this use of "REQUIRE_HOME_NODE_EXECUTABLE"; it is deprecated. rule

@mshabarov
Copy link
Contributor

mshabarov commented May 6, 2021 •
edited

Tested V20 Pre starter project from start.vaadin.com against node V16.0.0. Works fine with no errors.

@mshabarov mshabarov merged commit 31cf3ef into master May 6, 2021
@mshabarov mshabarov deleted the node16 branch May 6, 2021 06:34
Artur- added a commit that referenced this pull request May 18, 2021
@Artur-
fix: Upgrade auto-installed Node to v16 (#10772)
f5227c1 
Fixes #10637
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshabarov mshabarov mshabarov approved these changes

Assignees
No one assigned
Labels
prerelease version for platform 21.0.0 Released with Platform 21.0.0.alpha2 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Autoinstall Node 16
4 participants
@Artur- @vaadin-bot @mshabarov @ZheSun88