fix: pinned dependency only adds when modified #11894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caalador
added this to Iteration Reviews
in OLD Vaadin Flow ongoing work (Vaadin 10+)
via automation
Do not mark pin if no version is actually added or changed. With this npm install will not always be executed on reload and the copied modules will not disappear. Fixes #11888
caalador
force-pushed
the
issues/11888_hot_reload_master
branch
from
f73aa75
to
5b38579
Compare
|
SonarQube analysis reported 3 issues
|
denis-anisimov
approved these changes
Sep 21, 2021
OLD Vaadin Flow ongoing work (Vaadin 10+)
automation
moved this from Iteration Reviews
to Done - pending release
Sep 21, 2021
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 21, 2021
Do not mark pin if no version is actually added or changed. With this npm install will not always be executed on reload and the copied modules will not disappear. Fixes #11888
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 21, 2021
Do not mark pin if no version is actually added or changed. With this npm install will not always be executed on reload and the copied modules will not disappear. Fixes #11888
vaadin-bot
added a commit
that referenced
this pull request
Sep 21, 2021
Do not mark pin if no version is actually added or changed. With this npm install will not always be executed on reload and the copied modules will not disappear. Fixes #11888 Co-authored-by: caalador <mikael.grankvist@vaadin.com>
vaadin-bot
added a commit
that referenced
this pull request
Sep 21, 2021
Do not mark pin if no version is actually added or changed. With this npm install will not always be executed on reload and the copied modules will not disappear. Fixes #11888 Co-authored-by: caalador <mikael.grankvist@vaadin.com>
|
This ticket/PR has been released with platform 22.0.0.alpha5 and is also targeting the upcoming stable 22.0.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not mark pin if no version is actually
added or changed.
With this npm install will not always be
executed on reload.
Fixes #11888