fix: pinned dependency only adds when modified (#11894) (CP: 8.0) #11899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not mark pin if no version is actually added or changed. With this npm install will not always be executed on reload and the copied modules will not disappear. Fixes #11888
|
SonarQube analysis reported 3 issues
|
|
This PR is eligible for auto-merging policy, so it has been approved automatically.[Message is sent from bot] |
vaadin-review-bot
approved these changes
Sep 21, 2021
|
This PR has been merged with 'squash' method.[Message is sent from bot] |
|
This ticket/PR has been released with platform 21.0.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.