Disable sending updates to client for effectively non-visible nodes #15885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… has changed if testvalue differs from original value
|
Kudos, SonarCloud Quality Gate passed!
|
czp13
force-pushed
the
fix/do-not-send-updates-for-hidden-nodes
branch
from
f89442e
to
428cc97
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
mshabarov
pushed a commit
that referenced
this pull request
May 17, 2023
…15885) * Disable sending updates to client for effectively non-visible nodes * Fix test: Always set tested component visible first; only assume node has changed if testvalue differs from original value * Cleanup, and refactoring, in Element, StateNode, UIInternals classes + mvn formatter. --------- Co-authored-by: czp13 <61667986+czp13@users.noreply.github.com> Co-authored-by: Peter Czuczor <czuczor@gmail.com> (cherry picked from commit eab4f09)
mcollovati
pushed a commit
that referenced
this pull request
May 17, 2023
…des (#15885) (#16810) * Disable sending updates to client for effectively non-visible nodes * Fix test: Always set tested component visible first; only assume node has changed if testvalue differs from original value * Cleanup, and refactoring, in Element, StateNode, UIInternals classes + mvn formatter. --------- Co-authored-by: Teppo Kurki <teppo.kurki@vaadin.com> Co-authored-by: Peter Czuczor <czuczor@gmail.com>
mcollovati
pushed a commit
that referenced
this pull request
May 17, 2023
…des (#15885) (#16812) * Disable sending updates to client for effectively non-visible nodes * Fix test: Always set tested component visible first; only assume node has changed if testvalue differs from original value * Cleanup, and refactoring, in Element, StateNode, UIInternals classes + mvn formatter. --------- Co-authored-by: Teppo Kurki <teppo.kurki@vaadin.com> Co-authored-by: Peter Czuczor <czuczor@gmail.com>
mshabarov
pushed a commit
that referenced
this pull request
May 17, 2023
…15885) * Disable sending updates to client for effectively non-visible nodes * Fix test: Always set tested component visible first; only assume node has changed if testvalue differs from original value * Cleanup, and refactoring, in Element, StateNode, UIInternals classes + mvn formatter. --------- Co-authored-by: czp13 <61667986+czp13@users.noreply.github.com> Co-authored-by: Peter Czuczor <czuczor@gmail.com> (cherry picked from commit eab4f09)
mshabarov
pushed a commit
that referenced
this pull request
May 17, 2023
…15885) * Disable sending updates to client for effectively non-visible nodes * Fix test: Always set tested component visible first; only assume node has changed if testvalue differs from original value * Cleanup, and refactoring, in Element, StateNode, UIInternals classes + mvn formatter. --------- Co-authored-by: czp13 <61667986+czp13@users.noreply.github.com> Co-authored-by: Peter Czuczor <czuczor@gmail.com> (cherry picked from commit eab4f09)
mshabarov
pushed a commit
that referenced
this pull request
May 17, 2023
…15885) * Disable sending updates to client for effectively non-visible nodes * Fix test: Always set tested component visible first; only assume node has changed if testvalue differs from original value * Cleanup, and refactoring, in Element, StateNode, UIInternals classes + mvn formatter. --------- Co-authored-by: czp13 <61667986+czp13@users.noreply.github.com> Co-authored-by: Peter Czuczor <czuczor@gmail.com> (cherry picked from commit eab4f09)
mshabarov
added a commit
that referenced
this pull request
May 17, 2023
…15885) (#16819) * Disable sending updates to client for effectively non-visible nodes * Fix test: Always set tested component visible first; only assume node has changed if testvalue differs from original value * Cleanup, and refactoring, in Element, StateNode, UIInternals classes + mvn formatter. --------- Co-authored-by: czp13 <61667986+czp13@users.noreply.github.com> Co-authored-by: Peter Czuczor <czuczor@gmail.com> (cherry picked from commit eab4f09) Co-authored-by: Teppo Kurki <teppo.kurki@vaadin.com>
mshabarov
added a commit
that referenced
this pull request
May 17, 2023
…15885) (#16818) * Disable sending updates to client for effectively non-visible nodes * Fix test: Always set tested component visible first; only assume node has changed if testvalue differs from original value * Cleanup, and refactoring, in Element, StateNode, UIInternals classes + mvn formatter. --------- Co-authored-by: czp13 <61667986+czp13@users.noreply.github.com> Co-authored-by: Peter Czuczor <czuczor@gmail.com> (cherry picked from commit eab4f09) Co-authored-by: Teppo Kurki <teppo.kurki@vaadin.com>
mshabarov
added a commit
that referenced
this pull request
May 17, 2023
…15885) (#16817) * Disable sending updates to client for effectively non-visible nodes * Fix test: Always set tested component visible first; only assume node has changed if testvalue differs from original value * Cleanup, and refactoring, in Element, StateNode, UIInternals classes + mvn formatter. --------- Co-authored-by: czp13 <61667986+czp13@users.noreply.github.com> Co-authored-by: Peter Czuczor <czuczor@gmail.com> (cherry picked from commit eab4f09) Co-authored-by: Teppo Kurki <teppo.kurki@vaadin.com> Co-authored-by: Peter Czuczor <61667986+czp13@users.noreply.github.com>
czp13
added a commit
that referenced
this pull request
May 24, 2023
…odes (#15885) (CP: 1.0) Manually cherry-picked for 1.0: - Disable sending updates to client for effectively non-visible nodes - Fix test: Always set tested component visible first; only assume node has changed if testvalue differs from original value - Cleanup, and refactoring, in Element, StateNode, UIInternals classes + mvn formatter.
czp13
added a commit
that referenced
this pull request
May 24, 2023
…odes (#15885) (CP: 1.0) Manually cherry-picked for 1.0 (small changes around the stream peek and the filtering invocations part) - Disable sending updates to client for effectively non-visible nodes - Fix test: Always set tested component visible first; only assume node has changed if testvalue differs from original value - Cleanup, and refactoring, in Element, StateNode, UIInternals classes + mvn formatter.
czp13
added a commit
that referenced
this pull request
May 24, 2023
…odes (#15885) (CP: 1.0) Manually cherry-picked for 1.0 (small changes around the stream peek and the filtering invocations part, and owner Optional handling) - Disable sending updates to client for effectively non-visible nodes - Fix test: Always set tested component visible first; only assume node has changed if testvalue differs from original value - Cleanup, and refactoring, in Element, StateNode, UIInternals classes + mvn formatter.
czp13
added a commit
that referenced
this pull request
May 24, 2023
…odes (#15885) (CP: 1.0) Manually cherry-picked for 1.0 New changes through cherry picking: - small changes around the stream peek (sentToBrowser is not existing in this code base) - and the filtering invocations part, - and owner Optional handling, Old changes: - Disable sending updates to client for effectively non-visible nodes - Fix test: Always set tested component visible first; only assume node has changed if testvalue differs from original value - Cleanup, and refactoring, in Element, StateNode, UIInternals classes + mvn formatter.
mshabarov
pushed a commit
that referenced
this pull request
May 26, 2023
…nodes (CP: 1.0) (#16875) * chore:disable sending updates to client for effectively non-visible nodes (#15885) (CP: 1.0) Manually cherry-picked for 1.0 New changes through cherry picking: - small changes around the stream peek (sentToBrowser is not existing in this code base) - and the filtering invocations part, - and owner Optional handling, Old changes: - Disable sending updates to client for effectively non-visible nodes - Fix test: Always set tested component visible first; only assume node has changed if testvalue differs from original value - Cleanup, and refactoring, in Element, StateNode, UIInternals classes + mvn formatter. * chore: #16836 and #16855 PR-s merged to this one, and fine tuned for this code-base (remove detach listener when javascript execution completes, and nullify registration) - Added handling Optional<StateNode> for computeIfAbsent and other places, - Covering test class (and so tests) is/are fully missing from this version (need to add somewhere else), - Deleted/Commented invocation.then(callback, callback) as this concept is not existing here, but added other snippet for handling registration removes, - Tailored the code to the codebase.
mshabarov
added a commit
that referenced
this pull request
Sep 5, 2023
mshabarov
added a commit
that referenced
this pull request
Sep 7, 2023
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 7, 2023
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 7, 2023
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 7, 2023
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 7, 2023
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 7, 2023
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 7, 2023
vaadin-bot
added a commit
that referenced
this pull request
Sep 7, 2023
vaadin-bot
added a commit
that referenced
this pull request
Sep 7, 2023
vaadin-bot
added a commit
that referenced
this pull request
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.