fix: Fix regression when sync id check is disabled (#17238) (CP: 2.9) #17256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When syncId check is disabled, long-polling push cache filter always cached all messages. This change fixes the regression, by preventing message cache when syncId check is disabled.
|
Kudos, SonarCloud Quality Gate passed!
|
vaadin-review-bot
approved these changes
Jul 20, 2023
|
This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot] |
|
This ticket/PR has been released with Vaadin 14.10.4. |
mshabarov
pushed a commit
that referenced
this pull request
Aug 7, 2023
When syncId check is disabled, long-polling push cache filter always cached all messages. This change fixes the regression, by preventing message cache when syncId check is disabled. Co-authored-by: Tatu Lund <tatu@vaadin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.