Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: jsx files are not taken into front-end build from add-ons #17820

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

mstahv
Copy link
Member

@mstahv mstahv commented Oct 11, 2023

We already support tsx, but the more trivial jsx files don't seem to work. Something that people probably try first, especially if the embedded component is only using JS...

Type of change

  • Bugfix
  • [] Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

We already support tsx, but the more trivial jsx files don't seem to work.
Something that people probably try first, especially if the embedded component
is only using JS...
@mcollovati mcollovati added the Contribution PRs coming from the community or external to the team label Oct 11, 2023
@mcollovati
Copy link
Collaborator

Thanks, @mstahv.
Do you mind updating the tests to cover the added extensions, as done in #13323?

@mstahv
Copy link
Member Author

mstahv commented Oct 11, 2023

I was looking at that for a while, but modifying those jar files to include test files made me feel reluctant 😁

@github-actions
Copy link

github-actions bot commented Oct 11, 2023

Test Results

1 009 files  ±0  1 009 suites  ±0   1h 3m 7s ⏱️ -48s
6 475 tests ±0  6 434 ✔️ ±0  41 💤 ±0  0 ±0 
6 732 runs   - 2  6 684 ✔️  - 2  48 💤 ±0  0 ±0 

Results for commit d60a3a4. ± Comparison against base commit 75ec389.

♻️ This comment has been updated with latest results.

@mstahv
Copy link
Member Author

mstahv commented Oct 12, 2023

Thanks @caalador, here is a medal for you 🥇

Copy link
Collaborator

@mcollovati mcollovati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo in test error messages

Co-authored-by: Marco Collovati <marco@vaadin.com>
@mcollovati mcollovati changed the title bugfix: jsx files are not taken into front-end build from add-ons fix: jsx files are not taken into front-end build from add-ons Oct 12, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mcollovati mcollovati enabled auto-merge (squash) October 12, 2023 05:53
@mcollovati mcollovati merged commit 2650861 into main Oct 12, 2023
25 of 30 checks passed
@mcollovati mcollovati deleted the feature/jsx-support-for-addons branch October 12, 2023 05:54
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.3.0.alpha1 and is also targeting the upcoming stable 24.3.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants