-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: jsx files are not taken into front-end build from add-ons #17820
Conversation
We already support tsx, but the more trivial jsx files don't seem to work. Something that people probably try first, especially if the embedded component is only using JS...
I was looking at that for a while, but modifying those jar files to include test files made me feel reluctant 😁 |
Thanks @caalador, here is a medal for you 🥇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a typo in test error messages
flow-server/src/test/java/com/vaadin/flow/server/frontend/TaskCopyFrontendFilesTest.java
Outdated
Show resolved
Hide resolved
flow-server/src/test/java/com/vaadin/flow/server/frontend/TaskCopyFrontendFilesTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Marco Collovati <marco@vaadin.com>
Kudos, SonarCloud Quality Gate passed!
|
This ticket/PR has been released with Vaadin 24.3.0.alpha1 and is also targeting the upcoming stable 24.3.0 version. |
We already support tsx, but the more trivial jsx files don't seem to work. Something that people probably try first, especially if the embedded component is only using JS...
Type of change
Checklist
Additional for
Feature
type of change