Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable use of tsx files in add-ons #13323

Merged
merged 2 commits into from
Mar 21, 2022
Merged

Conversation

caalador
Copy link
Contributor

Also copy any tsx file resources
form add-on folders.

Fixes #13318

Also copy any tsx file resources
form add-on folders.

Fixes #13318
@github-actions
Copy link

github-actions bot commented Mar 21, 2022

Unit Test Results

   954 files  ±0     954 suites  ±0   41m 22s ⏱️ - 7m 53s
6 179 tests ±0  6 130 ✔️ ±0  49 💤 ±0  0 ±0 
6 394 runs   - 2  6 339 ✔️  - 2  55 💤 ±0  0 ±0 

Results for commit 406b76e. ± Comparison against base commit ab57d0b.

♻️ This comment has been updated with latest results.

mcollovati
mcollovati previously approved these changes Mar 21, 2022
@mcollovati mcollovati dismissed their stale review March 21, 2022 07:28

Approve button pressed by mistake

@mcollovati
Copy link
Collaborator

Aside from the failure on FrontendResourcesAreCopiedAfterCleaningTest.frontendResources_should_beCopiedFromJars_when_TaskUpdatePackagesRemovesThem test, LGTM

@caalador
Copy link
Contributor Author

Test is now fixed. Didn't notice that there was one more that used the same jar file copying.

@sonarcloud
Copy link

sonarcloud bot commented Mar 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 15 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mcollovati mcollovati merged commit e43fe93 into master Mar 21, 2022
@mcollovati mcollovati deleted the issues/11318_tsx_copy branch March 21, 2022 08:27
vaadin-bot pushed a commit that referenced this pull request Mar 21, 2022
Also copy any tsx file resources
form add-on folders.

Fixes #13318
caalador added a commit that referenced this pull request Mar 22, 2022
Also copy any tsx file resources
form add-on folders.

Fixes #13318

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.tsx File doesnt get added to the "flow-frontend" folder in targets.
3 participants