feat: Use binding object to check for Binder#hasChanges

[benedikt-roth]

Description

Allows to check whether specific binding has been changed. So far there is only a generic Binder#hasChanges, which checks all bindings. The new method allows to check whether a specific binding has changes.

Fixes #17395

Type of change

• Bugfix
• Feature

Checklist

• I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
• I have added a description following the guideline.
• The issue is created in the corresponding repository and I have referenced it.
• I have added tests to ensure my change is effective and works as intended.
• New and existing tests are passing locally with my change.
• I have performed self-review and corrected misspellings.

Additional for Feature type of change

• Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

[CLAassistant]

All committers have signed the CLA.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[mcollovati]

@benedikt-roth do you mind signing the CLA and formatting the source code as suggested in #17861 (comment)?

[github-actions]

Test Results

1 014 files  +   539  1 014 suites  +539   1h 14m 46s ⏱️ + 37m 30s
6 507 tests +5 753  6 466 ✔️ +5 742  41 💤 +11  0 ❌ ±0 
6 762 runs  +5 781  6 714 ✔️ +5 769  48 💤 +12  0 ❌ ±0 

Results for commit 3dc1e66. ± Comparison against base commit c77d34f.

♻️ This comment has been updated with latest results.

[benedikt-roth]

@benedikt-roth do you mind signing the CLA and formatting the source code as suggested in #17861 (comment)?

Sure, done that and also fixed the formatting.

[mcollovati]

Thanks for the contribution, the change looks good.
I would add tests for hasChanges when the binding has been removed from the binder.

I also wonder if we could add the hasChanges() method also on the Binding interface, so that it would be possible to simply do a binding.hasChanges().
The implementation in BindingImpl could use the internal binder field to check it this binding is in the changeBindings set.
And it will throw and IllegalStateException if the binder is null.

However, this is not mandatory for the PR to be merged

[benedikt-roth]

Thanks for the contribution, the change looks good. I would add tests for hasChanges when the binding has been removed from the binder.

I also wonder if we could add the hasChanges() method also on the Binding interface, so that it would be possible to simply do a binding.hasChanges(). The implementation in BindingImpl could use the internal binder field to check it this binding is in the changeBindings set. And it will throw and IllegalStateException if the binder is null.

However, this is not mandatory for the PR to be merged

Let me look into this one. Definitely would be useful. If it is a quick change, let's include this in this PR.

[mcollovati]

The change looks good to me. Let's see if the validation passes.
Good job @benedikt-roth

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[vaadin-bot]

This ticket/PR has been released with Vaadin 24.3.0.alpha1 and is also targeting the upcoming stable 24.3.0 version.