Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Populate UI.getCurrent() before running ErrorHandler #18127

Merged
merged 7 commits into from
Nov 28, 2023
Merged

Populate UI.getCurrent() before running ErrorHandler #18127

merged 7 commits into from
Nov 28, 2023

Conversation

mvysny
Copy link
Member

@mvysny mvysny commented Nov 24, 2023

Description

Populates UI.getCurrent() correctly before the ErrorHandler is called.

Fixes #10533

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@mvysny mvysny requested a review from Artur- November 24, 2023 10:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 24, 2023 •
edited
Loading

Test Results

1 043 files  ±  0  1 043 suites  ±0   1h 11m 41s ⏱️ - 1m 52s
6 714 tests +  1  6 669 ✔️ +  1  45 💤 ±0  0 ❌ ±0 
6 990 runs   - 26  6 936 ✔️  - 24  54 💤  - 2  0 ❌ ±0 

Results for commit 5e6d203. ± Comparison against base commit a86af7b.

♻️ This comment has been updated with latest results.

@mshabarov mshabarov requested review from tepi and removed request for caalador November 27, 2023 12:38
@mvysny mvysny requested a review from Legioth November 28, 2023 13:44
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tepi tepi merged commit da7ffab into main Nov 28, 2023
26 checks passed
@tepi tepi deleted the fix/10533 branch November 28, 2023 15:44
rodolforfq pushed a commit that referenced this pull request Feb 8, 2024
@mvysny @rodolforfq
Populate UI.getCurrent() before running ErrorHandler (#18127)
4f1bee8 
* chore: add test testing for correct UI.current instance in ErrorHandler

* fix: Sets the current UI to this before calling ErrorHandler. Fixes #10533

* chore: star import

* chore: star import

* refactoring: use CurrentInstace to preserve current UI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knoobie knoobie knoobie left review comments

@tepi tepi tepi approved these changes

@Artur- Artur- Awaiting requested review from Artur-

@Legioth Legioth Awaiting requested review from Legioth

Assignees
No one assigned
Labels
+0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI.getCurrent() is null in ErrorHandler
5 participants
@mvysny @Legioth @tepi @knoobie @vaadin-bot