New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate removeDataGenerator #4494

Merged
merged 1 commit into from Aug 9, 2018

Conversation

Projects
None yet
4 participants
@Legioth
Member

Legioth commented Aug 8, 2018

Inspired by #4401


This change is Reviewable

* @param generator
* the data generator to remove
*/
@Deprecated
void removeDataGenerator(DataGenerator<T> generator);

This comment has been minimized.

@vaadin-bot

vaadin-bot Aug 8, 2018

Collaborator

INFO Do not forget to remove this deprecated code someday. rule

@vaadin-bot

vaadin-bot Aug 8, 2018

Collaborator

INFO Do not forget to remove this deprecated code someday. rule

@vaadin-bot

This comment has been minimized.

Show comment
Hide comment
@vaadin-bot

vaadin-bot Aug 8, 2018

Collaborator

SonarQube analysis reported 1 issue

  • INFO 1 info

Watch the comments in this conversation to review them.

Collaborator

vaadin-bot commented Aug 8, 2018

SonarQube analysis reported 1 issue

  • INFO 1 info

Watch the comments in this conversation to review them.

@denis-anisimov

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: 1 unresolved discussion, 0 of 1 LGTMs obtained, and 1 stale

@denis-anisimov

Dismissed @vaadin-bot from a discussion.
Reviewable status: :shipit: complete! all discussions resolved, 1 of 1 LGTMs obtained

@denis-anisimov denis-anisimov merged commit 35f5287 into master Aug 9, 2018

4 checks passed

Flow Pull Requests (Flow Public) TeamCity build finished
Details
code-review/reviewable 1/1 LGTMs
Details
license/cla Contributor License Agreement is signed.
Details
sonarqube SonarQube reported 1 issue, no criticals or blockers

@denis-anisimov denis-anisimov deleted the deprecate_removeDataGenerator branch Aug 9, 2018

denis-anisimov added a commit that referenced this pull request Aug 9, 2018

ZheSun88 added a commit that referenced this pull request Aug 9, 2018

@ZheSun88 ZheSun88 added this to the 1.1.0.beta2 milestone Aug 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment