fix: use the latest Spring version #7028
Conversation
This fixes the Spring version mismatch between flow-server-3.0-SNAPSHOT and vaadin-spring-13.0-SNAPSHOT. Also removes the workaround added to avoid a runtime failure caused by the version mismatch (added in #7024).
project-bot
bot
added this to External Reviews
in OLD Vaadin Flow ongoing work (Vaadin 10+)
This fixes the Spring version mismatch between flow-server and the flow-ccdm-connect test. Also remove the dependency to `vaadin-spring` to break the circular dependency.
vlukashov
force-pushed
the
vl/fix-spring-version-mismatch
branch
from
6c45fc0
to
238e452
Compare
There is a separate task to remove the dependency later: #7030
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, 0 of 1 LGTMs obtained (waiting on @manolo and @vaadin-bot)
flow-server/src/main/java/com/vaadin/flow/server/connect/VaadinConnectControllerConfiguration.java, line 62 at r1 (raw file):
Previously, vaadin-bot (Vaadin Bot) wrote…
Reduce this anonymous class number of lines from 23 to at most 20, or make it a named class.
Done.
|
SonarQube analysis reported 1 issue Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
There was a problem hiding this comment.
Reviewed 2 of 4 files at r1, 2 of 2 files at r2.
Reviewable status: 1 unresolved discussion, 0 of 1 LGTMs obtained (waiting on @vaadin-bot)
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, 0 of 1 LGTMs obtained (waiting on @vaadin-bot)
There was a problem hiding this comment.
Dismissed @vaadin-bot from a discussion.
Reviewable status: all discussions resolved, 0 of 1 LGTMs obtained
There was a problem hiding this comment.
Reviewable status:
complete! all discussions resolved, 1 of 1 LGTMs obtained
This fixes the Spring version mismatch between flow-server-3.0-SNAPSHOT and vaadin-spring-13.0-SNAPSHOT.
Also removes the workaround added to avoid a runtime failure caused by the version mismatch (added in #7024).
This change is