Drop all es5 mentions and support #7229
Conversation
- Remove WebBrowser parameter from methods - Correct tests and test data - Update webpack config
project-bot
bot
added this to External Reviews
in OLD Vaadin Flow ongoing work (Vaadin 10+)
| } | ||
|
|
||
| private Element createInlineDependencyElement(VaadinSession session, VaadinRequest request, JsonObject dependency, | ||
| Dependency.Type type) { | ||
| private Element createInlineDependencyElement(VaadinSession session, |
There was a problem hiding this comment.
| case JAVASCRIPT: | ||
| dependencyElement = createJavaScriptElement(url, false, null); | ||
| break; | ||
| case JS_MODULE: |
There was a problem hiding this comment.
| null), | ||
| path -> service.resolveResource(path, browser), this); | ||
| path -> service.getResourceAsStream(path, null), | ||
| path -> service.resolveResource(path), this); |
There was a problem hiding this comment.
| null), | ||
| resourcePath -> resolveResource(resourcePath, browser), | ||
| resourcePath -> getResourceAsStream(resourcePath, null), | ||
| resourcePath -> resolveResource(resourcePath), |
There was a problem hiding this comment.
There was a problem hiding this comment.
Reviewed 50 of 50 files at r1.
Reviewable status: 5 unresolved discussions, 0 of 1 LGTMs obtained (waiting on @denis-anisimov)
flow-server/src/main/java/com/vaadin/flow/server/UnsupportedBrowserHandler.java, line 50 at r1 (raw file):
+ " padding-top: 2em;" + CLOSING_BRACKET + " sub," + " small {" + " color: #999;" + CLOSING_BRACKET + " </style>" + "</head>";
The readability got strictly worse by this auto-formatting. Perhaps leave the original formatting and surround the block with
//@formatter:off
...
//@formatter:on
to prevent automatic formatting?
There was a problem hiding this comment.
Reviewable status: 5 unresolved discussions, 0 of 1 LGTMs obtained (waiting on @denis-anisimov and @joheriks)
flow-server/src/main/java/com/vaadin/flow/server/UnsupportedBrowserHandler.java, line 50 at r1 (raw file):
Previously, joheriks (Johannes Eriksson) wrote…
The readability got strictly worse by this auto-formatting. Perhaps leave the original formatting and surround the block with
//@formatter:off ... //@formatter:onto prevent automatic formatting?
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status: 4 unresolved discussions, 1 of 1 LGTMs obtained (waiting on @denis-anisimov)
|
SonarQube analysis reported 11 issues
Watch the comments in this conversation to review them. 7 extra issuesNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
There was a problem hiding this comment.
Dismissed @vaadin-bot from 4 discussions.
Reviewable status:complete! all discussions resolved, 1 of 1 LGTMs obtained
This fixes the documentation CI build after the vaadin/flow#7229 PR was merged.
This fixes the documentation CI build after the vaadin/flow#7229 PR was merged.
Fixes #6856
This change is