Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop ES5 (IE11, old Safari) support in Flow 3.0+ #6856

Closed
4 tasks done
Artur- opened this issue Nov 7, 2019 · 3 comments
Closed
4 tasks done

Drop ES5 (IE11, old Safari) support in Flow 3.0+ #6856

Artur- opened this issue Nov 7, 2019 · 3 comments

Comments

@Artur-
Copy link
Member

Artur- commented Nov 7, 2019

As decided and explained here https://vaadin.com/blog/vaadin-14-is-the-last-major-version-to-support-ie11, Flow 3.0+ will not support IE11.

What needs to be done for this:

  • Make sure that an app opened with IE11 & older Safari versions shows the "browser too old" page
    • Only newest major Safari version should be supported, anything less than that should go to Unsupported Browser page (regardless if newer versions support ES6)
  • Do not transpile client side to ES5
    • Drop extra babel dependencies
    • Drop any IFs in Java for checking if ES5 is supported
    • Drop any URL resolving related to ES5
    • Drop plugin-transform-block-scoping from webpack
  • Make sure docs do not mention anything specific to IE11 (or old Safari)
  • Do not run tests on IE11
@pleku pleku added this to Inbox - needs triage in OLD Vaadin Flow ongoing work (Vaadin 10+) Nov 29, 2019
@pleku pleku moved this from Inbox - needs triage to Product backlog in OLD Vaadin Flow ongoing work (Vaadin 10+) Dec 17, 2019
@pleku
Copy link
Contributor

pleku commented Dec 18, 2019

According to https://caniuse.com/#feat=es6-module-dynamic-import we would need ES5 transpilation (or something else) to have dynamic import support for Safari 10.

So this would mean that we don't support older Safari than 11.1, and we should drop the no-module polyfill https://caniuse.com/#feat=es6-module.

Also, Safari 12 will not be supported on desktop anyway for macOS, but for iOS there will probably be lots of old devices.

@pleku pleku changed the title Drop IE11 support in Flow 3.0+ Drop ES5 (IE11, old Safari) support in Flow 3.0+ Dec 18, 2019
@pleku pleku moved this from Product backlog to Ready To Go in OLD Vaadin Flow ongoing work (Vaadin 10+) Dec 20, 2019
@denis-anisimov denis-anisimov self-assigned this Dec 20, 2019
@project-bot project-bot bot moved this from Ready To Go to In progress in OLD Vaadin Flow ongoing work (Vaadin 10+) Dec 20, 2019
ZheSun88 added a commit that referenced this issue Dec 31, 2019
according to the comment #6856 (comment) , we should support Safari 11.1 +, which means safari 11.1 is included in the version range.
@pleku
Copy link
Contributor

pleku commented Jan 2, 2020

Also to clarify from #7244, currently the minimum supported Safari version ought to be 12.

@denis-anisimov
Copy link
Contributor

IE11 tests have not been run against CCDM branch but they are removed anyway (so there is no anymore IE11 validation even in the master branch).

Done and done.

OLD Vaadin Flow ongoing work (Vaadin 10+) automation moved this from In progress to Done - pending release Jan 6, 2020
Vaadin Flow enhancements backlog (Vaadin 10+) automation moved this from Next for Dev. Team to Done / Pending Release Jan 6, 2020
@pleku pleku added this to the CCDM MVP milestone Jan 6, 2020
pleku added a commit that referenced this issue Jan 9, 2020
pleku added a commit that referenced this issue Jan 9, 2020
pleku added a commit that referenced this issue Jan 9, 2020
pleku added a commit that referenced this issue Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
OLD Vaadin Flow ongoing work (Vaadin ...
  
Done - pending release
Vaadin Flow enhancements backlog (Vaa...
  
Done / Pending Release
Development

No branches or pull requests

3 participants