Correct Safari version range to support Safari 11.1 #7243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
according to the comment #6856 (comment) , we should support Safari 11.1 +, which means safari 11.1 is included in the version range.
project-bot
bot
added this to External Reviews
in OLD Vaadin Flow ongoing work (Vaadin 10+)
Closed
pleku
suggested changes
Jan 2, 2020
There was a problem hiding this comment.
Actually, for V15 the minimum should be Safari 12, according to @Artur-
Jury is still out on whether 12 or 13 should be the base
So even if Flow in theory would support Safari 11.1+, we cannot and will not guarantee that everything does.
OLD Vaadin Flow ongoing work (Vaadin 10+)
automation
moved this from External Reviews
to Changes Requested
Jan 2, 2020
ZheSun88
commented
Jan 2, 2020
There was a problem hiding this comment.
yes, according to Artur, there will be a clarification next week. this PR and the related ticket can be closed now.
Reviewable status: all discussions resolved, 0 of 1 LGTMs obtained (waiting on @pleku)
OLD Vaadin Flow ongoing work (Vaadin 10+)
automation
moved this from Changes Requested
to Done - pending release
Jan 2, 2020
pleku
removed this from Done - pending release
in OLD Vaadin Flow ongoing work (Vaadin 10+)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to the comment #6856 (comment) , we should support Safari 11.1 +, which means that safari 11.1 is included in the version range.
#7244
This change is