Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delay location.reload when session expires #7707

Merged
merged 1 commit into from
Feb 28, 2020
Merged

delay location.reload when session expires #7707

merged 1 commit into from
Feb 28, 2020

Conversation

manolo
Copy link
Member

@manolo manolo commented Feb 27, 2020 •
edited

Fixes vaadin/hilla#334

This change is Reviewable

@manolo manolo self-assigned this Feb 28, 2020
platosha
platosha approved these changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@platosha platosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 3 files at r1, 2 of 2 files at r3.
Reviewable status: :shipit: complete! all discussions resolved, 1 of 1 LGTMs obtained (waiting on @haiwan and @ptdatkhtn)

@platosha
Copy link
Contributor

No API changes here, I guess we could target/3.0? @manolo

@manolo manolo merged commit 0093409 into master Feb 28, 2020
@manolo manolo deleted the mcm/master/fix-reload branch February 28, 2020 11:43
@manolo manolo added the hilla Issues related to Hilla label Feb 28, 2020
ptdatkhtn pushed a commit that referenced this pull request Mar 2, 2020
@manolo @ptdatkhtn
delay location.reload when session expires (#7707)
b37233b 
Fixes #7581
ptdatkhtn added a commit that referenced this pull request Mar 2, 2020
@ptdatkhtn
delay location.reload when session expires (#7707) (#7731)
5e30ca4 
* delay location.reload when session expires (#7707)

Fixes #7581
haijian-vaadin added a commit that referenced this pull request Mar 11, 2020
@haijian-vaadin
Revert "delay location.reload when session expires (#7707)"
a4ae259 
This reverts commit 0093409.
manolo pushed a commit that referenced this pull request Mar 11, 2020
@haijian-vaadin
Revert "delay location.reload when session expires (#7707)" (#7789)
94098e3 
Detected a reload loop under certain circumstances.
haijian-vaadin added a commit that referenced this pull request Mar 11, 2020
@haijian-vaadin
Revert "delay location.reload when session expires (#7707) (#7731)"
f967f10 
This reverts commit 5e30ca4.
haijian-vaadin added a commit that referenced this pull request Mar 11, 2020
@haijian-vaadin
Revert "delay location.reload when session expires (#7707) (#7731)" (#…
a94e2db 
…7795)

* Revert "delay location.reload when session expires (#7707) (#7731)"

This reverts commit 5e30ca4.
manolo added a commit that referenced this pull request Mar 27, 2020
@manolo
Revert "Revert "delay location.reload when session expires (#7707)" (#…
b0ebccd 
…7789)"

This reverts commit 94098e3.
manolo added a commit that referenced this pull request Mar 31, 2020
@manolo
Revert "Revert "delay location.reload when session expires (#7707)" (#…
50f387d 
…7789)"

This reverts commit 94098e3.
manolo added a commit that referenced this pull request Mar 31, 2020
@manolo
Revert "Revert "delay location.reload when session expires (#7707)" (#…
aa35f55 
…7789)"

This reverts commit 94098e3.
haijian-vaadin pushed a commit that referenced this pull request Apr 1, 2020
@manolo @haijian-vaadin
Revert "Revert "delay location.reload when session expires (#7707)" (#…
98fedc0 
…7789)"

This reverts commit 94098e3.
haijian-vaadin added a commit that referenced this pull request Aug 18, 2020
@haijian-vaadin
Revert "Revert "Revert "delay location.reload when session expires (#…
472493d 
…7707)" (#7789)""

This reverts commit 98fedc0.
haijian-vaadin added a commit that referenced this pull request Aug 19, 2020
@haijian-vaadin
Revert "Revert "Revert "delay location.reload when session expires (#…
433b5d1 
…7707)" (#7789)""

This reverts commit 98fedc0.
haijian-vaadin added a commit that referenced this pull request Aug 21, 2020
@haijian-vaadin
fix: Revert delay location.reload when session expires(#7707) (#8870)
8598f5a 
* Revert "Revert "Revert "delay location.reload when session expires (#7707)" (#7789)""

This reverts commit 98fedc0.

* chore: split router session expiration test cases
haijian-vaadin added a commit that referenced this pull request Aug 21, 2020
@haijian-vaadin
fix: Revert delay location.reload when session expires(#7707) (#8870)
b4d7e0f 
* Revert "Revert "Revert "delay location.reload when session expires (#7707)" (#7789)""

This reverts commit 98fedc0.

* chore: split router session expiration test cases
haijian-vaadin added a commit that referenced this pull request Aug 24, 2020
@haijian-vaadin
fix: Revert delay location.reload when session expires(#7707) (#8870)
8fa0028 
* Revert "Revert "Revert "delay location.reload when session expires (#7707)" (#7789)""

This reverts commit 98fedc0.

* chore: split router session expiration test cases
pleku pushed a commit that referenced this pull request Aug 24, 2020
@haijian-vaadin @pleku
fix: Revert delay location.reload when session expires(#7707) (#8870)
862714c 
* Revert "Revert "Revert "delay location.reload when session expires (#7707)" (#7789)""

This reverts commit 98fedc0.

* chore: split router session expiration test cases
mshabarov pushed a commit that referenced this pull request Aug 24, 2020
@haijian-vaadin @mshabarov
fix: Revert delay location.reload when session expires(#7707) (#8870)
3d1316e 
* Revert "Revert "Revert "delay location.reload when session expires (#7707)" (#7789)""

This reverts commit 98fedc0.

* chore: split router session expiration test cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@platosha platosha platosha approved these changes

@haiwan haiwan Awaiting requested review from haiwan

@ptdatkhtn ptdatkhtn Awaiting requested review from ptdatkhtn

Assignees

@manolo manolo

Labels
hilla Issues related to Hilla +1.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CCDM: when invalidating session programatically, previous page is reloaded
3 participants
@manolo @platosha @vaadin-bot