Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert delay location.reload when session expires(#7707) #8870

Merged
merged 2 commits into from
Aug 21, 2020

Conversation

haijian-vaadin
Copy link
Contributor

@haijian-vaadin haijian-vaadin commented Aug 19, 2020

Fixes #8627

@haijian-vaadin haijian-vaadin added the hilla Issues related to Hilla label Aug 19, 2020
@haijian-vaadin haijian-vaadin self-assigned this Aug 19, 2020
@platosha
Copy link
Contributor

The title and description could be a bit more informative perhaps. Otherwise looks good.

@haijian-vaadin haijian-vaadin changed the title Haijian/fix logout fix: Revert delay location.reload when session expires(#7707) Aug 20, 2020
@haijian-vaadin haijian-vaadin merged commit 8598f5a into master Aug 21, 2020
@haijian-vaadin haijian-vaadin deleted the haijian/fix-logout branch August 21, 2020 06:30
haijian-vaadin added a commit that referenced this pull request Aug 21, 2020
* Revert "Revert "Revert "delay location.reload when session expires (#7707)" (#7789)""

This reverts commit 98fedc0.

* chore: split router session expiration test cases
haijian-vaadin added a commit that referenced this pull request Aug 24, 2020
* Revert "Revert "Revert "delay location.reload when session expires (#7707)" (#7789)""

This reverts commit 98fedc0.

* chore: split router session expiration test cases
pleku pushed a commit that referenced this pull request Aug 24, 2020
* Revert "Revert "Revert "delay location.reload when session expires (#7707)" (#7789)""

This reverts commit 98fedc0.

* chore: split router session expiration test cases
mshabarov pushed a commit that referenced this pull request Aug 24, 2020
* Revert "Revert "Revert "delay location.reload when session expires (#7707)" (#7789)""

This reverts commit 98fedc0.

* chore: split router session expiration test cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hilla Issues related to Hilla +0.0.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logout code doesn't work in the master branch
3 participants