Support Element.setProperty for lists and maps #8587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artur-
force-pushed
the
element-setpropertylistmap
branch
3 times, most recently
from
cf5b648
to
77f718d
Compare
vaadin-bot
reviewed
Jun 22, 2020
| try { | ||
| return Json.parse(objectMapper.writeValueAsString(bean)); | ||
| } catch (JsonProcessingException e) { | ||
| throw new RuntimeException("Error converting bean to JSON", e); |
There was a problem hiding this comment.
Artur-
force-pushed
the
element-setpropertylistmap
branch
from
77f718d
to
2ebc53d
Compare
vaadin-bot
reviewed
Jun 22, 2020
| try { | ||
| return Json.instance().parse(objectMapper.writeValueAsString(map)); | ||
| } catch (JsonProcessingException e) { | ||
| throw new RuntimeException("Error converting map to JSON", e); |
There was a problem hiding this comment.
vaadin-bot
reviewed
Jun 22, 2020
| try { | ||
| return Json.instance().parse(objectMapper.writeValueAsString(list)); | ||
| } catch (JsonProcessingException e) { | ||
| throw new RuntimeException("Error converting list to JSON", e); |
There was a problem hiding this comment.
Artur-
force-pushed
the
element-setpropertylistmap
branch
from
2ebc53d
to
c692a2d
Compare
joheriks
suggested changes
Jun 25, 2020
joheriks
previously approved these changes
Jun 25, 2020
|
SonarQube analysis reported 3 issues
Watch the comments in this conversation to review them. |
Artur-
force-pushed
the
element-setpropertylistmap
branch
from
88c9662
to
13cd5c8
Compare
joheriks
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7308
Based on #8584 to avoid unnecessary conflicts