Support Element.setPropertyBean #8584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artur-
force-pushed
the
element-setpropertybean
branch
from
8c7e333
to
0945d4f
Compare
Artur-
force-pushed
the
element-setpropertybean
branch
from
0945d4f
to
48c5068
Compare
vaadin-bot
reviewed
Jun 18, 2020
| try { | ||
| return Json.parse(objectMapper.writeValueAsString(bean)); | ||
| } catch (JsonProcessingException e) { | ||
| throw new RuntimeException("Error converting bean to JSON", e); |
There was a problem hiding this comment.
Artur-
force-pushed
the
element-setpropertybean
branch
from
48c5068
to
33c2f65
Compare
joheriks
suggested changes
Jun 24, 2020
flow-server/src/main/java/com/vaadin/flow/internal/JsonUtils.java
Outdated
Show resolved
Hide resolved
joheriks
approved these changes
Jun 25, 2020
|
SonarQube analysis reported 1 issue
Watch the comments in this conversation to review them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7307