Maven plugin: exposed the settings 'node.version' and 'node.download.… #8675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#8659) * Maven plugin: exposed the settings 'node.version' and 'node.download.root' * Use new URI() instead of URI.create(), to validate user input * Fixed NPE in BuildFrontendMojoTest * Refactoring: mojo initialization refactored to Maven convention
vaadin-bot
reviewed
Jul 1, 2020
| * Vaadin-default node version - see {@link FrontendTools} for details. | ||
| */ | ||
| @Parameter(property = "node.version", defaultValue = FrontendTools.DEFAULT_NODE_VERSION) | ||
| protected String nodeVersion; |
There was a problem hiding this comment.
|
SonarQube analysis reported 14 issues
Watch the comments in this conversation to review them. Top 10 extra issuesNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
vaadin-bot
reviewed
Jul 1, 2020
| * Example: <code>"https://nodejs.org/dist/"</code>. | ||
| */ | ||
| @Parameter(property = "node.download.root", defaultValue = NodeInstaller.DEFAULT_NODEJS_DOWNLOAD_ROOT) | ||
| protected String nodeDownloadRoot; |
There was a problem hiding this comment.
jm-ferreira
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…… (#8659)
Maven plugin: exposed the settings 'node.version' and 'node.download.root'
Use new URI() instead of URI.create(), to validate user input
Fixed NPE in BuildFrontendMojoTest
Refactoring: mojo initialization refactored to Maven convention