hand-picked fix to #5043 combobox suggestion popup on scroll #10307

OlliTietavainenVaadin · 2017-11-09T11:14:38Z

Slightly modified version of #9869 for Vaadin 7.7

This change is

wbadam · 2017-11-10T09:59:02Z

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 10 unresolved discussions.

client/src/main/java/com/vaadin/client/ui/VFilterSelect.java, line 345 at r1 (raw file):

        private final MouseWheeler mouseWheeler = new MouseWheeler();

Please remove spaces

client/src/main/java/com/vaadin/client/ui/VFilterSelect.java, line 489 at r1 (raw file):

            return val | 0;
        }-*/;

Please remove spaces

client/src/main/java/com/vaadin/client/ui/VFilterSelect.java, line 500 at r1 (raw file):

                    .getLeft());
        }

Please remove spaces

client/src/main/java/com/vaadin/client/ui/VFilterSelect.java, line 720 at r1 (raw file):

            super.onPreviewNativeEvent(event);
        }

Please remove spaces

client/src/main/java/com/vaadin/client/ui/VFilterSelect.java, line 727 at r1 (raw file):

        private void updatePopupPositionOnScroll() {
            if (!scrollPending) {
                AnimationScheduler.get().requestAnimationFrame(new AnimationCallback() {

Please remove spaces

client/src/main/java/com/vaadin/client/ui/VFilterSelect.java, line 740 at r1 (raw file):

            }
        }

Please remove spaces

uitest/src/main/java/com/vaadin/tests/components/combobox/ComboboxPopupScrolling.java, line 39 at r1 (raw file):

                combobox3, combobox4);
        addComponent(hl);

Please remove spaces

uitest/src/test/java/com/vaadin/tests/components/combobox/ComboboxPopupScrollingTest.java, line 28 at r1 (raw file):

import com.vaadin.testbench.elements.UIElement;
import com.vaadin.tests.tb3.MultiBrowserTest;
import com.vaadin.tests.tb3.newelements.ComboBoxElement;

Is there a significant difference between this and com.vaadin.testbench.elements.ComboBoxElement?

uitest/src/test/java/com/vaadin/tests/components/combobox/ComboboxPopupScrollingTest.java, line 69 at r1 (raw file):

            sleep(500);
        } catch (InterruptedException ignored) {

On master, TB throws throw new RuntimeException(e); here. Not sure if it's important.

uitest/src/test/java/com/vaadin/tests/components/combobox/ComboboxPopupScrollingTest.java, line 80 at r1 (raw file):

                newPopupLocation.y - popupLocation.y);
    }

Please remove spaces

Comments from Reviewable

OlliTietavainenVaadin · 2017-11-10T10:11:18Z

Review status: 0 of 3 files reviewed at latest revision, 10 unresolved discussions.

client/src/main/java/com/vaadin/client/ui/VFilterSelect.java, line 345 at r1 (raw file):