Move ComboBox popup with ComboBox on scroll #9869
Conversation
Keep the ComboBox popup at the same position relative to the ComboBox when the view is scrolled. Fixes #5043
|
Reviewed 2 of 3 files at r1. uitest/src/main/java/com/vaadin/tests/components/combobox/ComboboxPopupScrolling.java, line 44 at r1 (raw file):
Is this tall enough to require scrolling? Comments from Reviewable |
|
Review status: 2 of 3 files reviewed at latest revision, 1 unresolved discussion. uitest/src/main/java/com/vaadin/tests/components/combobox/ComboboxPopupScrolling.java, line 44 at r1 (raw file): Previously, ahie (Aleksi Hietanen) wrote…
Our tests are run at 1500x850, and also the top part of the test UI takes quite a bit of space. Comments from Reviewable |
|
Reviewed 1 of 3 files at r1. uitest/src/main/java/com/vaadin/tests/components/combobox/ComboboxPopupScrolling.java, line 44 at r1 (raw file): Previously, hesara (Henri Sara) wrote…
Could consider setting the size dynamically, not blocking. Comments from Reviewable |
Keep the ComboBox popup at the same position relative to the ComboBox when the view is scrolled. Fixes #5043
Keep the ComboBox popup at the same position relative to the ComboBox when the view is scrolled. Fixes #5043
Keep the ComboBox popup at the same position relative to the ComboBox
when the view is scrolled.
Fixes #5043
This change is