fix: Ensure that side effects of readBean does not set hasChanges true #12455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TatuLund
changed the title
Ansku
approved these changes
Oct 27, 2021
Ansku
pushed a commit
that referenced
this pull request
Oct 29, 2021
anssit
pushed a commit
to vaadin/flow
that referenced
this pull request
Nov 9, 2021
…12181) JavaDoc of hasChanges says: "Check whether any of the bound fields' have uncommitted changes since last explicit call to readBean(Object), removeBean(), writeBean(Object)} or writeBeanIfValid(Object)." If readBean has converters, they will be run and field values updated accordingly. Furthermore if fields have value change listeners that will produce further changes in values, this should be considered according to above as part of readBean procedure and thus hasChanges still should return false. Cherry pick from: vaadin/framework#12455
anssit
pushed a commit
to vaadin/flow
that referenced
this pull request
Nov 9, 2021
…12181) JavaDoc of hasChanges says: "Check whether any of the bound fields' have uncommitted changes since last explicit call to readBean(Object), removeBean(), writeBean(Object)} or writeBeanIfValid(Object)." If readBean has converters, they will be run and field values updated accordingly. Furthermore if fields have value change listeners that will produce further changes in values, this should be considered according to above as part of readBean procedure and thus hasChanges still should return false. Cherry pick from: vaadin/framework#12455 (cherry picked from commit 4e36fd9)
joheriks
pushed a commit
to vaadin/flow
that referenced
this pull request
Nov 9, 2021
…12181) (#12317) JavaDoc of hasChanges says: "Check whether any of the bound fields' have uncommitted changes since last explicit call to readBean(Object), removeBean(), writeBean(Object)} or writeBeanIfValid(Object)." If readBean has converters, they will be run and field values updated accordingly. Furthermore if fields have value change listeners that will produce further changes in values, this should be considered according to above as part of readBean procedure and thus hasChanges still should return false. Cherry pick from: vaadin/framework#12455 (cherry picked from commit 4e36fd9) Co-authored-by: Tatu Lund <tatu@vaadin.com>
anssit
pushed a commit
to vaadin/flow
that referenced
this pull request
Nov 9, 2021
…12181) JavaDoc of hasChanges says: "Check whether any of the bound fields' have uncommitted changes since last explicit call to readBean(Object), removeBean(), writeBean(Object)} or writeBeanIfValid(Object)." If readBean has converters, they will be run and field values updated accordingly. Furthermore if fields have value change listeners that will produce further changes in values, this should be considered according to above as part of readBean procedure and thus hasChanges still should return false. Cherry pick from: vaadin/framework#12455 (cherry picked from commit 4e36fd9)
joheriks
pushed a commit
to vaadin/flow
that referenced
this pull request
Nov 9, 2021
…12181) (#12319) JavaDoc of hasChanges says: "Check whether any of the bound fields' have uncommitted changes since last explicit call to readBean(Object), removeBean(), writeBean(Object)} or writeBeanIfValid(Object)." If readBean has converters, they will be run and field values updated accordingly. Furthermore if fields have value change listeners that will produce further changes in values, this should be considered according to above as part of readBean procedure and thus hasChanges still should return false. Cherry pick from: vaadin/framework#12455 (cherry picked from commit 4e36fd9) Co-authored-by: Tatu Lund <tatu@vaadin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JavaDoc of hasChanges says
"Check whether any of the bound fields' have uncommitted changes since last explicit call to {@link #readBean(Object)}, {@link #removeBean()}, * {@link #writeBean(Object)} or {@link #writeBeanIfValid(Object)}."
If readBean has converters, they will be run and field values updated accordingly. Furthermore if fields have value change listeners that will produce further changes in values, this should be considered according to above as part of readBean producedure and thus hasChanges still should return false.
fixes: #9581