fix: Clear changed bindings after initing field values #12181
Conversation
|
Totally random: Do you plan to forward port vaadin/framework#12360 as well? |
|
SonarQube analysis reported 8 issues
|
|
TatuLund
changed the title
mshabarov
requested review from
mshabarov and
anssit
and removed request for
mshabarov
|
Hi @TatuLund and @anssit, when i performed cherry-pick to this commit to 8.0, i have encountered the following issue. Can you take a look and pick it manually? |
|
Hi @TatuLund and @anssit, when i performed cherry-pick to this commit to 2.7, i have encountered the following issue. Can you take a look and pick it manually? |
…12181) JavaDoc of hasChanges says: "Check whether any of the bound fields' have uncommitted changes since last explicit call to readBean(Object), removeBean(), writeBean(Object)} or writeBeanIfValid(Object)." If readBean has converters, they will be run and field values updated accordingly. Furthermore if fields have value change listeners that will produce further changes in values, this should be considered according to above as part of readBean procedure and thus hasChanges still should return false. Cherry pick from: vaadin/framework#12455 (cherry picked from commit 4e36fd9)
…12181) (#12317) JavaDoc of hasChanges says: "Check whether any of the bound fields' have uncommitted changes since last explicit call to readBean(Object), removeBean(), writeBean(Object)} or writeBeanIfValid(Object)." If readBean has converters, they will be run and field values updated accordingly. Furthermore if fields have value change listeners that will produce further changes in values, this should be considered according to above as part of readBean procedure and thus hasChanges still should return false. Cherry pick from: vaadin/framework#12455 (cherry picked from commit 4e36fd9) Co-authored-by: Tatu Lund <tatu@vaadin.com>
…12181) JavaDoc of hasChanges says: "Check whether any of the bound fields' have uncommitted changes since last explicit call to readBean(Object), removeBean(), writeBean(Object)} or writeBeanIfValid(Object)." If readBean has converters, they will be run and field values updated accordingly. Furthermore if fields have value change listeners that will produce further changes in values, this should be considered according to above as part of readBean procedure and thus hasChanges still should return false. Cherry pick from: vaadin/framework#12455 (cherry picked from commit 4e36fd9)
…12181) (#12319) JavaDoc of hasChanges says: "Check whether any of the bound fields' have uncommitted changes since last explicit call to readBean(Object), removeBean(), writeBean(Object)} or writeBeanIfValid(Object)." If readBean has converters, they will be run and field values updated accordingly. Furthermore if fields have value change listeners that will produce further changes in values, this should be considered according to above as part of readBean procedure and thus hasChanges still should return false. Cherry pick from: vaadin/framework#12455 (cherry picked from commit 4e36fd9) Co-authored-by: Tatu Lund <tatu@vaadin.com>
|
This ticket/PR has been released with platform 22.0.0.beta2 and is also targeting the upcoming stable 22.0.0 version. |
JavaDoc of hasChanges says
"Check whether any of the bound fields' have uncommitted changes since last explicit call to {@link #readBean(Object)}, {@link #removeBean()}, * {@link #writeBean(Object)} or {@link #writeBeanIfValid(Object)}."
If readBean has converters, they will be run and field values updated accordingly. Furthermore if fields have value change listeners that will produce further changes in values, this should be considered according to above as part of readBean producedure and thus hasChanges still should return false.
Cherry pick from: vaadin/framework#12455