Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: disallow parametrized items in auto menu (#2392) (CP: 24.4) #2456

Merged
merged 3 commits into from
May 22, 2024

Conversation

Lodin
Copy link
Contributor

@Lodin Lodin commented May 22, 2024

No description provided.

@Lodin Lodin added the hilla Issues related to Hilla label May 22, 2024
@Lodin Lodin requested review from platosha and taefi May 22, 2024 14:05
@Lodin Lodin changed the base branch from main to 24.4 May 22, 2024 14:05
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (24.4@bcebc95). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             24.4    #2456   +/-   ##
=======================================
  Coverage        ?   95.07%           
=======================================
  Files           ?       66           
  Lines           ?     4510           
  Branches        ?      646           
=======================================
  Hits            ?     4288           
  Misses          ?      181           
  Partials        ?       41           
Flag Coverage Δ
unittests 95.07% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

platosha
platosha previously approved these changes May 22, 2024
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ZheSun88 ZheSun88 enabled auto-merge (rebase) May 22, 2024 18:12
@ZheSun88 ZheSun88 merged commit d430e69 into 24.4 May 22, 2024
15 checks passed
@ZheSun88 ZheSun88 deleted the cherry-pick-2392-to-24-4 branch May 22, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hilla Issues related to Hilla
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants