Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Portlet definition should not require user to implement WebComponentExporter #34

Closed
joheriks opened this issue Oct 9, 2019 · 0 comments · Fixed by #41
Closed

Portlet definition should not require user to implement WebComponentExporter #34

joheriks opened this issue Oct 9, 2019 · 0 comments · Fixed by #41
Assignees
@joheriks
Labels
enhancement New feature or request
Milestone
1.0.0.alpha1

Comments

@joheriks
Copy link
Contributor

joheriks commented Oct 9, 2019 •
edited by pleku
Loading

Currently, the content of a portlet is exported as a web component by adding an explicit WebComponentExporter subclass in parallel with the VaadinPortlet subclass.
This should not be required.

Acceptance criteria

  • The web component is exported behind the scenes, using the web component exporter feature
  • The web component tag (which needs to be unique for each VaadinPortlet subclass), is generated from the portlet name (defined in portlet.xml) or the subclass name (whichever is easier).
  • The abstract VaadinPortlet should be extends VaadinPortlet<VIEW extends Component> and take in the ViewClass so that the portlet can set up things by view interfaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joheriks joheriks

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0.alpha1
Development

Successfully merging a pull request may close this issue.

VaadinPortlet should implement ExportsWebComponent. vaadin/portlet
2 participants
@caalador @joheriks