-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move spring-boot-starter dependency back to platform #320
Comments
This was proposed by @mstahv as per recommended by @snicoll (?). If we do this, eg. just release the Or then we add all the component integrations as a dependency to the |
The only thing that rings a bell is regarding the I am not sure I understand how that discussion is related to this particular issue though. |
Yes that is true, and that is what we had originally also for V10. But currently since in V10 the framework (flow) doesn't include the components nor have those as a dependency, those need to be declared separately. That is what the platform dependencies are for, eg. That is why we moved the
The issue is that if we move the starter to be back in the |
Sorry, I still don't understand why adding the starter to the If you decide to require a separate bom, then so be it but my general recommendation about this is as follows:
|
It does so. What makes it weird to me, sorry it might be just due to my limited knowledge, is that then we'd have to release the In each platform release first the Thus, when you declare a dependency to Oh how fun Maven is (sorry again) |
Sorry to comment on a situation I don't fully understand but that looks broken to me. The very purpose of a BOM is to be a public contract for your users. If you release the bom first and then The valid process for a BOM is to release the various components and at the very end the BOM that defines the various versions to use for a particular version of the bom (here the Vaadin version). An alternative is to have the BOM as part of the release process of the rest of those various components so that they are all released in one go. |
Maybe the issue is that vaadin-core uses vaadin-bom (and vica versa). There is kind of a circular dependency. I guess we should change it so that vaadin-core should define the versions of its dependencies without the bom (maybe define versions as properties in parent -> can be defined just once for both core and bom). Just throwing ideas. |
Yes, there is a circular dependency. We've now added the starter to the platform BOM vaadin/platform@d28eee6 But the starter is still released separately from the platform, which is an issue as it should be inside the platform. We'll fix that by moving the starter from this repository to the platform. |
👍 That probably makes it easier to do the release properly. Land this before attacking that: #323 (review) |
till now, i think this ticket can be closed. |
The starters still isn't moved to platform repository, is there a separate issue for that? |
I will reopen this issue. |
There has been a mistake in the platform BOM, simply just a typo in the version property for the There will soon be a new platform & vaadin-spring-boot-starter releases, version 10.0.1, which fixes that. |
I don't understand what should be done in the end. |
Let me try to summarize my thoughts from a start.spring.io and general Maven perspective. Vaadin 8 offers a This issue is about how Vaadin 10 broke that. I am asking to restore to this behaviour and, if not possible, discuss why that is and what options are available. One important point in the discussion is "Vaadin artifacts". A "Vaadin" bom can't really have an opinion about third party dependencies (for instance SLF4J) unless Vaadin considers itself a "platform". If they do, that's fine but I'd argue that there is a need for what Vaadin 10 has been removed from start.spring.io for this reason and I hope to see it re-added soon. Let me know if I can help in any way. |
Sure. And this is what my comment about: there should be a clear instructions what to do (and this is request for our team). |
What is still remaining is:
So thus the starter module should be moved and released in the platform, instead of here. |
Should this ticket be moved into platform then ? |
I don't think it matters that much, but sure. |
Issue moved to vaadin/platform #257 via ZenHub |
Well, I'm personally not familiar with agreements and the way of adding modules/release build of platform. |
This is basically the reverse change for the issue #298
remove the separate release configuration for spring-boot-starter(snapshot and publish),
revert POM setting.
The text was updated successfully, but these errors were encountered: