Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next] Split custom element definition to separate file #16

Closed
web-padawan opened this issue Nov 20, 2019 · 1 comment
Closed

[next] Split custom element definition to separate file #16

web-padawan opened this issue Nov 20, 2019 · 1 comment
Assignees
@web-padawan
Labels
next This affects the LitElement based version

Comments

@web-padawan
Copy link
Member

The idea is to follow the MWC convention:

  • src/vaadin-details-base.ts for a class,
  • src/vaadin-details.ts for a component.

That way we could extend vaadin-details in vaadin-accordion without having the dependent element unexpectedly defined as a side effect.
@web-padawan web-padawan added the next This affects the LitElement based version label Nov 20, 2019
@web-padawan web-padawan self-assigned this Nov 20, 2019
@web-padawan web-padawan mentioned this issue Nov 20, 2019
Merged
@web-padawan
Copy link
Member Author

Fixed by #17 and released as 2.0.0-alpha2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@web-padawan web-padawan

Labels
next This affects the LitElement based version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@web-padawan