Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data-binding in selected item #131

Merged
merged 3 commits into from
Jun 27, 2018
Merged

Fix data-binding in selected item #131

merged 3 commits into from
Jun 27, 2018

Conversation

yuriy-fix
Copy link
Contributor

@yuriy-fix yuriy-fix commented Jun 20, 2018

Fixes #128


This change is Reviewable

@tomivirkki
Copy link
Member

src/vaadin-dropdown-menu.html, line 355 at r1 (raw file):

          this.addEventListener('iron-resize', this._boundSetPosition);

          const origForwardHostProp = this._overlayElement._instance && this._overlayElement._instance.forwardHostProp;

Why in connectedCallback? _overlayElement is set somewhere else. And its _instance may not be defined.


Comments from Reviewable

@coveralls
Copy link

coveralls commented Jun 20, 2018

Pull Request Test Coverage Report for Build 798

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 96.97%

Totals Coverage Status
Change from base Build 778: 0.2%
Covered Lines: 111
Relevant Lines: 113

💛 - Coveralls

@web-padawan
Copy link
Member

Review status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @YuriyVaadin)


src/vaadin-dropdown-menu.html, line 69 at r1 (raw file):

  <script>
    (function() {
      let memorizedTemplate;

BTW why has this been renamed? "to memoize" is a correct word for this


Comments from Reviewable

@yuriy-fix
Copy link
Contributor Author

Review status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @YuriyVaadin)


src/vaadin-dropdown-menu.html, line 69 at r1 (raw file):

Previously, web-padawan (Sergey Kulikov) wrote…

BTW why has this been renamed? "to memoize" is a correct word for this

Was thinking it's a typo. Reverted.


src/vaadin-dropdown-menu.html, line 355 at r1 (raw file):

Previously, tomivirkki (Tomi Virkki) wrote…

Why in connectedCallback? _overlayElement is set somewhere else. And its _instance may not be defined.

Checking it now in ready where the template is assigned to the _overlayElement and it's defined.


Comments from Reviewable

@tomivirkki
Copy link
Member

src/vaadin-dropdown-menu.html, line 355 at r1 (raw file):

Previously, YuriyVaadin (Yuriy Yevstihnyeyev) wrote…

Checking it now in ready where the template is assigned to the _overlayElement and it's defined.

ready isn't the right place for this either. Added a new issue that explains why. Not a blocker for this pr though #138


Comments from Reviewable

@tomivirkki
Copy link
Member

:lgtm:


Reviewed 1 of 2 files at r1, 6 of 6 files at r2.
Review status: :shipit: complete! all files reviewed, all discussions resolved


Comments from Reviewable

@tomivirkki tomivirkki merged commit 071916d into master Jun 27, 2018
@tomivirkki tomivirkki deleted the fix/data-binding branch June 27, 2018 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants