-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix data-binding in selected item #131
Conversation
src/vaadin-dropdown-menu.html, line 355 at r1 (raw file):
Why in connectedCallback? _overlayElement is set somewhere else. And its _instance may not be defined. Comments from Reviewable |
Review status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @YuriyVaadin) src/vaadin-dropdown-menu.html, line 69 at r1 (raw file):
BTW why has this been renamed? "to memoize" is a correct word for this Comments from Reviewable |
07bc53b
to
2b2569e
Compare
2b2569e
to
bc9dc2c
Compare
Review status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @YuriyVaadin) src/vaadin-dropdown-menu.html, line 69 at r1 (raw file): Previously, web-padawan (Sergey Kulikov) wrote…
Was thinking it's a typo. Reverted. src/vaadin-dropdown-menu.html, line 355 at r1 (raw file): Previously, tomivirkki (Tomi Virkki) wrote…
Checking it now in Comments from Reviewable |
src/vaadin-dropdown-menu.html, line 355 at r1 (raw file): Previously, YuriyVaadin (Yuriy Yevstihnyeyev) wrote…
ready isn't the right place for this either. Added a new issue that explains why. Not a blocker for this pr though #138 Comments from Reviewable |
Reviewed 1 of 2 files at r1, 6 of 6 files at r2. Comments from Reviewable |
Fixes #128
This change is