feat: use web components 21.0.0-alpha2, fix tests #978

web-padawan · 2021-05-11T13:38:21Z

Description

Updated the web components to new major
Added the @vaadin/vaadin-template-renderer to bring back removed Polymer template APIs.

web-padawan · 2021-05-12T13:33:55Z

Remaining failures:

javascript error: arguments[0]._scrollToIndex is not a function

java.lang.AssertionError: A grid cell was expected to have text content but had none.
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at com.vaadin.flow.component.grid.it.GridTestScrollingOver100kLinesIT.lambda$toStringIsUsedForObjectSerialization$1(GridTestScrollingOver100kLinesIT.java:53)
	at java.util.ArrayList.forEach(ArrayList.java:1257)
	at com.vaadin.flow.component.grid.it.GridTestScrollingOver100kLinesIT.toStringIsUsedForObjectSerialization(GridTestScrollingOver100kLinesIT.java:49)

java.lang.NullPointerException
	at com.vaadin.flow.component.grid.testbench.GridElement.getFirstVisibleRowIndex(GridElement.java:72)
	at com.vaadin.flow.component.grid.testbench.GridElement.isRowInView(GridElement.java:174)
	at com.vaadin.flow.component.grid.testbench.GridElement.getCell(GridElement.java:115)
	at com.vaadin.flow.component.grid.testbench.GridElement.getCell(GridElement.java:100)
	at com.vaadin.flow.component.grid.it.RecalculateColumnWidthsIT.columnsRecalculateAfterDataChange(RecalculateColumnWidthsIT.java:40)

And the one about lit-element import:

java.lang.AssertionError: Expected only [Deprecation] warnings in the logs
Expected: a string containing "HTML Imports"
     but: was "http://172.16.1.126:8080/VAADIN/build/vaadin-1-0efec97cdf48f1cc4870.cache.js 507:8 "The main 'lit-element' module entrypoint is deprecated. Please update your imports to use the 'lit' package: 'lit' and 'lit/decorators.ts' or import from 'lit-element/lit-element.ts'.""

web-padawan · 2021-05-12T13:50:46Z

Few other failures:

java.lang.AssertionError: Item count doesn't match expected:<1501> but was:<1800>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at com.vaadin.flow.component.grid.dataview.AbstractItemCountGridIT.verifyRows(AbstractItemCountGridIT.java:99)
	at com.vaadin.flow.component.grid.dataview.ItemCountEstimateGridIT.itemCountEstimateGrid_estimateLessThanCurrentRange_estimateNotChanged(ItemCountEstimateGridIT.java:102)

java.lang.AssertionError: Grid should be able to scroll after changing to defined size expected:<517> but was:<516>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at com.vaadin.flow.component.grid.dataview.ItemCountUnknownGridIT.undefinedSizeGrid_switchesToDefinedSize_sizeChanges(ItemCountUnknownGridIT.java:84)

org.junit.ComparisonFailure: Cell content should have not updated expected:<[EDITED]> but was:<[0]>
	at org.junit.Assert.assertEquals(Assert.java:117)
	at com.vaadin.flow.component.grid.it.GridItemRefreshPageIT.dataProviderRefreshItem_gridDoesntTouchOtherItemsOnDOM(GridItemRefreshPageIT.java:92)

tomivirkki · 2021-05-14T13:36:31Z

...ion-tests/src/test/java/com/vaadin/flow/component/grid/dataview/ItemCountEstimateGridIT.java

-        verifyRows(1501);
+        verifyRows(1800);

-        setEstimate(1600);
-        verifyRows(1600);
+        setEstimate(1700);
+        verifyRows(1700);


The previous tests were written with the assumption that the scrollToIndex wouldn't continue to the desired index once the last scrollable index before increasing the range has been reached. This works as expected with the new version so the grid actually ends up at index 1500 after scrollToRow(1500), even if the effective size is increased dynamically.

tomivirkki · 2021-05-14T13:37:06Z

...tion-tests/src/test/java/com/vaadin/flow/component/grid/dataview/ItemCountUnknownGridIT.java

-        int expectedLastItem = 517;
+        int VIEWPORT_ITEM_CAPACITY = 16;
+        int expectedLastItem = 500 + VIEWPORT_ITEM_CAPACITY;


Same as https://github.com/vaadin/flow-components/pull/978/files#r632532693

tomivirkki · 2021-05-14T13:37:13Z

...tion-tests/src/test/java/com/vaadin/flow/component/grid/dataview/ItemCountUnknownGridIT.java

-        Assert.assertEquals(999, grid.getLastVisibleRowIndex());
+        Assert.assertEquals(1000 + VIEWPORT_ITEM_CAPACITY, grid.getLastVisibleRowIndex());


Same as https://github.com/vaadin/flow-components/pull/978/files#r632532693

tomivirkki · 2021-05-14T13:38:44Z

...-tests/src/test/java/com/vaadin/flow/component/grid/it/GridTestScrollingOver100kLinesIT.java

-            String slotName = vgcc.getAttribute("slot")
-                    .replace("vaadin-grid-cell-content-", "");
-            if (Integer.parseInt(slotName) <= 180) {
+            TestBenchElement slot = vgcc.getPropertyElement("assignedSlot");
+            if (headerSlots.contains(slot) || bodySlots.contains(slot)) {


This test relied the cell content elements in the light DOM belonging to body and header starting from an arbitrary index 180.

tomivirkki · 2021-05-14T13:41:46Z

...-grid-flow-integration-tests/src/test/java/com/vaadin/flow/component/grid/it/GridViewIT.java

-        waitUntil(driver -> getCells(grid).stream()
-                .filter(cell -> text.equals(cell.getText())).findFirst()
-                .isPresent());
+        waitUntil(driver -> {
+            List<?> cellContentTexts = (List<?>) getCommandExecutor()
+                    .executeScript(
+                            "return Array.from(arguments[0].querySelectorAll('vaadin-grid-cell-content')).map(cell => cell.textContent)",
+                            grid);
+            return cellContentTexts.contains(text);
+        });


For some reason getting the cells via Selenium API resulted in different set than what querySelectorAll returns. Fixed to use pure JS approach instead.

tomivirkki · 2021-05-14T13:43:45Z

...ntegration-tests/src/test/java/com/vaadin/flow/component/grid/it/GridVirtualScrollingIT.java

-                "return arguments[0]._firstVisibleIndex+arguments[0]._vidxOffset",
-                grid);
+                "return arguments[0]._firstVisibleIndex", grid);


_vidxOffset is now a concept inside the virtualizer and doesn't concern grid. Now _firstVisibleIndex includes the offset value (it's still not public API!)

vaadin-bot · 2021-05-17T11:53:54Z

SonarQube analysis reported 222 issues

46 critical
37 major
128 minor
11 info

Top 10 issues

AvatarGroup.java#L395: Define a constant instead of duplicating this literal "The translation should not be null" 3 times.
GeneratedVaadinCheckbox.java#L226: Define a constant instead of duplicating this literal "indeterminate" 3 times.
GeneratedVaadinCheckbox.java#L287: Define a constant instead of duplicating this literal "checked" 5 times.
GeneratedVaadinCheckboxGroup.java#L297: Define a constant instead of duplicating this literal "invalid" 3 times.
GeneratedVaadinCheckboxGroup.java#L384: Define a constant instead of duplicating this literal "value" 4 times.
GeneratedVaadinComboBox.java#L430: Define a constant instead of duplicating this literal "opened" 3 times.
GeneratedVaadinComboBox.java#L623: Define a constant instead of duplicating this literal "filter" 3 times.
GeneratedVaadinComboBox.java#L656: Define a constant instead of duplicating this literal "selectedItem" 3 times.
GeneratedVaadinComboBox.java#L860: Define a constant instead of duplicating this literal "invalid" 3 times.
GeneratedVaadinComboBox.java#L1423: Define a constant instead of duplicating this literal "value" 4 times.

feat: update web components to 21.0.0-alpha1

99ac250

web-padawan force-pushed the v21-alpha1 branch from f937280 to 99ac250 Compare May 11, 2021 13:38

chore: update vaadin-template-renderer imports

35ffe9e

ZheSun88 approved these changes May 12, 2021

View reviewed changes

pekam mentioned this pull request May 12, 2021

feat: add theme API to MessageListItem #979

Merged

9 tasks

tomivirkki force-pushed the v21-alpha1 branch 2 times, most recently from 35a72b4 to 2684934 Compare May 12, 2021 12:59

tomivirkki force-pushed the v21-alpha1 branch from 2684934 to 31ed2fd Compare May 12, 2021 13:39

vlukashov added the no-polymer Removing Polymer from Vaadin public APIs label May 14, 2021

tomivirkki force-pushed the v21-alpha1 branch 3 times, most recently from f730e4d to a2f0932 Compare May 14, 2021 09:11

tomivirkki mentioned this pull request May 14, 2021

fix: make sure rows are generated to an empty grid with heightByRows vaadin/web-components#387

Merged

tomivirkki force-pushed the v21-alpha1 branch 2 times, most recently from 2dcf077 to 4035eb2 Compare May 14, 2021 13:30

tomivirkki reviewed May 14, 2021

View reviewed changes

tomivirkki force-pushed the v21-alpha1 branch from 4035eb2 to 71a119c Compare May 14, 2021 15:49

tomivirkki mentioned this pull request May 14, 2021

fix: handle leading hidden body rows vaadin/web-components#389

Merged

fix: fix use of private API and tests (wip)

88e367d

tomivirkki force-pushed the v21-alpha1 branch from 71a119c to 88e367d Compare May 14, 2021 16:09

web-padawan added 2 commits May 17, 2021 11:23

Update web components to 21.0.0-alpha2

ad007cc

Update deprecation warning in DatePicker IT

ebb7cad

web-padawan changed the title ~~feat: update web components to 21.0.0-alpha1~~ feat: use web components 21.0.0-alpha2, fix tests May 17, 2021

tomivirkki and others added 4 commits May 17, 2021 13:12

fix: add import to vaadin-template-renderer

85eea6b

fix: add missing imports to vaadin-template-renderer

f98b1ab

test: fix vaadin-notification tests

0bd7f66

chore: run mvn formatter

031a10c

tomivirkki approved these changes May 17, 2021

View reviewed changes

web-padawan merged commit 4cfbc14 into master May 17, 2021

web-padawan deleted the v21-alpha1 branch May 17, 2021 12:20

arenk mentioned this pull request Nov 8, 2021

Error when sorting empty grid (Cannot read properties of undefined) #2321

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: use web components 21.0.0-alpha2, fix tests #978

feat: use web components 21.0.0-alpha2, fix tests #978

web-padawan commented May 11, 2021

web-padawan commented May 12, 2021

web-padawan commented May 12, 2021

tomivirkki May 14, 2021

tomivirkki May 14, 2021

tomivirkki May 14, 2021

tomivirkki May 14, 2021

tomivirkki May 14, 2021

tomivirkki May 14, 2021

vaadin-bot commented May 17, 2021

		Assert.assertEquals(999, grid.getLastVisibleRowIndex());
		Assert.assertEquals(1000 + VIEWPORT_ITEM_CAPACITY, grid.getLastVisibleRowIndex());

feat: use web components 21.0.0-alpha2, fix tests #978

feat: use web components 21.0.0-alpha2, fix tests #978

Conversation

web-padawan commented May 11, 2021

Description

web-padawan commented May 12, 2021

web-padawan commented May 12, 2021

tomivirkki May 14, 2021

Choose a reason for hiding this comment

tomivirkki May 14, 2021

Choose a reason for hiding this comment

tomivirkki May 14, 2021

Choose a reason for hiding this comment

tomivirkki May 14, 2021

Choose a reason for hiding this comment

tomivirkki May 14, 2021

Choose a reason for hiding this comment

tomivirkki May 14, 2021

Choose a reason for hiding this comment

vaadin-bot commented May 17, 2021

Top 10 issues