Skip to content
This repository has been archived by the owner on Dec 12, 2022. It is now read-only.

DatePicker in Grid doesn't show in first row #570

Closed
firestormdong opened this issue Mar 6, 2019 · 6 comments
Closed

DatePicker in Grid doesn't show in first row #570

firestormdong opened this issue Mar 6, 2019 · 6 comments
Labels
waiting for author PR has been reviewed, but needs further changes from the author

Comments

@firestormdong
Copy link

firestormdong commented Mar 6, 2019

Not sure if related to vaadin/flow#5025
I'm using vaadin 12.0.7
Here's my code:

        Grid<LocalDate> grid = new Grid<>();
        grid.addColumn(LocalDate::toString).setHeader("Simple Column");
        grid.addComponentColumn(value -> {
            DatePicker datePicker = new DatePicker();
            datePicker.setValue(value);
            return datePicker;
        }).setHeader("Component Column");
        grid.setItems(
                LocalDate.of(2019, 1, 1),
                LocalDate.of(2019, 2, 2),
                LocalDate.of(2019, 3, 3)
        );

The screenshot in latest Chrome:
image

The screenshot in Firefox which is expected:
image

@denis-anisimov
Copy link

Hmm.

I cannot reproduce it with the latest Grid SNAPSHOT and also with Grid 1.2 SNAPSHOT.
Could you please try the latest 13.0.0 platform?

Also : if you still have an issue with 12.0.7 then we will need the exact versions of everything you use.
It's Grid version , date picker version.
Exact Chrome version, OS version.

The easiest way to provide info about component versions is to use https://github.com/vaadin/skeleton-starter-flow as a base, modify it to provide a usecase and attach it to the ticket.
We will be able to find out Grid and date picker versions from there.
But we will still need Chrome version and your OS version.

@denis-anisimov denis-anisimov added the waiting for author PR has been reviewed, but needs further changes from the author label Mar 6, 2019
@firestormdong
Copy link
Author

All the components I used are the versions referenced in vaadin-core:12.0.7
Grid: vaadin-grid:5.2.5 vaadin-grid-flow:2.1.5
DatePicker: vaadin-date-picker:3.3.2 vaadin-date-picker-flow:1.2.3

Chrome: Version 72.0.3626.119 (Official Build) (64-bit)
OS: Windows 10 Enterprise Version 1803 (OS Build 17134.590)

I'll try the versions you mentioned.

@firestormdong
Copy link
Author

Attached the project based on skeleton-starter-flow-12: skeleton-starter-flow-12.zip

Just found that the first time opening the page in Chrome do work well.
To reproduce the issue, you need to refresh the page (F5 or Ctrl+R).

@firestormdong
Copy link
Author

And I just tested in Vaadin 13.0.0, this issue is also reproducible.

@firestormdong
Copy link
Author

Any update to this?

@web-padawan
Copy link
Member

This appears to be the same as vaadin/flow#5025 (Chrome regression, now fixed). Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
waiting for author PR has been reviewed, but needs further changes from the author
Projects
None yet
Development

No branches or pull requests

3 participants