Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using inside chrome packaged app #20

Closed
kzahel opened this issue Jun 5, 2015 · 2 comments
Closed

Using inside chrome packaged app #20

kzahel opened this issue Jun 5, 2015 · 2 comments
Assignees
Milestone

Comments

@kzahel
Copy link

kzahel commented Jun 5, 2015

I wanted to try out vaadin-grid inside a Chrome packaged app, but VaadinGridImport.nocache.js attempts to do a document.write (not allowed) which throws an exception and causes everything to break.

Also it modifies document.onbeforeunload, etc, which will also not work.

Also why is this file obfuscated? Is there an un-obfuscated version that I can use easily?

@Saulis
Copy link
Contributor

Saulis commented Jun 7, 2015

Hi!

Unfortunately I'm not familiar with Chrome Package Apps, but if #16 causes them to break, we need to investigate it further.

<v-grid> is based on the Vaadin Framework Grid component and it's implemented in Java using GWT. It's compiled into minified/obfuscated Javascript by default, and in our case VaadinGridImport.nocache.js the size goes down ~248KB from ~902KB normal version.

If it helps, you can clone vaadin/components and run gulp gwt --gwt-pretty to compile a prettified version. You can join our Gitter chat if you need further instructions.

@jouni jouni added the <v-grid> label Jun 9, 2015
@jouni jouni modified the milestones: 0.3.0, “Next” Jun 18, 2015
@cwayfinder
Copy link

Issue with document.write has been resolved. See #16 for details. Please let us know how this works for you.

@Saulis Saulis modified the milestones: 0.3.0-beta3, “Next” Jun 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants